Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: enrollment success #2067

Merged
merged 6 commits into from
May 20, 2024
Merged

Feat: enrollment success #2067

merged 6 commits into from
May 20, 2024

Conversation

lalver1
Copy link
Member

@lalver1 lalver1 commented May 1, 2024 •
edited

Closes #2015

@lalver1 lalver1 self-assigned this May 1, 2024
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels May 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024 •
edited

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/core
  models.py
  benefits/enrollment
  views.py
Project Total  

This report was generated by python-coverage-comment-action

@lalver1 lalver1 force-pushed the feat/enrollment-success-copy branch 2 times, most recently from 87b775d to 901f23b Compare May 1, 2024 20:25
@lalver1 lalver1 force-pushed the feat/enrollment-success-copy branch from 901f23b to 9a1a5e3 Compare May 6, 2024 22:17
@lalver1 lalver1 force-pushed the feat/enrollment-success-copy branch 2 times, most recently from a779f6d to 75d50d6 Compare May 17, 2024 20:49
@lalver1 lalver1 force-pushed the feat/enrollment-success-copy branch from 75d50d6 to d9687f8 Compare May 20, 2024 13:53
@lalver1 lalver1 marked this pull request as ready for review May 20, 2024 14:11
@lalver1 lalver1 requested a review from a team as a code owner May 20, 2024 14:11
@thekaveman thekaveman mentioned this pull request May 20, 2024
Open
2 tasks
@thekaveman
Copy link
Member

Taking a look at this now 👀

thekaveman
thekaveman requested changes May 20, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. Just some minor cleanups requested.

tests/pytest/core/test_models.py Outdated Show resolved Hide resolved
benefits/enrollment/templates/enrollment/success--sacrt-light-rail.html Outdated Show resolved Hide resolved
@lalver1 lalver1 force-pushed the feat/enrollment-success-copy branch from d9687f8 to 3e67b99 Compare May 20, 2024 17:53
@thekaveman thekaveman mentioned this pull request May 20, 2024
Open
thekaveman
thekaveman approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @lalver1!!

@lalver1
Copy link
Member Author

lalver1 commented May 20, 2024

Thanks @thekaveman! And thanks for the super helpful review!

@lalver1 lalver1 merged commit c07ae69 into dev May 20, 2024
13 checks passed
@lalver1 lalver1 deleted the feat/enrollment-success-copy branch May 20, 2024 21:43
@thekaveman thekaveman mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran left review comments

@thekaveman thekaveman thekaveman approved these changes

Assignees

@lalver1 lalver1

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Milestone
Improved UX for agency card enrollment
Development

Successfully merging this pull request may close these issues.

Enrollment success: update copy and spacing
3 participants
@lalver1 @thekaveman @angela-tran