Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to test #231

Merged
merged 20 commits into from
Nov 30, 2021
Merged

Deploy to test #231

merged 20 commits into from
Nov 30, 2021

Conversation

thekaveman
Copy link
Member

No description provided.

machikoyasuda and others added 20 commits November 19, 2021 01:49
Bumps [cryptography](https://github.com/pyca/cryptography) from 35.0.0 to 36.0.0.
- [Release notes](https://github.com/pyca/cryptography/releases)
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@35.0.0...36.0.0)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [cypress](https://github.com/cypress-io/cypress) from 9.0.0 to 9.1.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js)
- [Commits](cypress-io/cypress@v9.0.0...v9.1.0)

---
updated-dependencies:
- dependency-name: cypress
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…e/cypress-9.1.0

chore(deps-dev): bump cypress from 9.0.0 to 9.1.0 in /tests/e2e
before this change, the /help URL was first processed
through the TransitAgencyPathConverter, generating
unnecessary logs and errors

this change moves the agency pattern/path converter to the end
of the URL list, allowing the other URLs to take precedence
avoids some unnecessary processing and logs
make this request async via JavaScript on the page, instead of
on the server immediately when the view processes

this will allow for more nuanced error messages if e.g.
the token cannot be acquired, easier testing of the EV flow,
and offers the potential for retrying the token acquisition on failure
the test can now run/pass since the confirmation page can now
load without an access token!
@thekaveman thekaveman added this to the November 2021 milestone Nov 30, 2021
@thekaveman thekaveman added this to In progress in Benefits 2021 via automation Nov 30, 2021
Benefits 2021 automation moved this from In progress to Reviewer approved Nov 30, 2021
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These code changes and the dev instance look good to me 👍

image

@thekaveman thekaveman merged commit a411844 into test Nov 30, 2021
Benefits 2021 automation moved this from Reviewer approved to Done Nov 30, 2021
@github-actions github-actions bot added the deployment [auto] Pull requests that deploy to test or prod label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment [auto] Pull requests that deploy to test or prod
Projects
No open projects
Benefits 2021
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants