Deploy to prod #250
Merged
Deploy to prod #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will make it possible to load via a glob pattern e.g.
python manage.py loaddata fixtures/*.json
while ensuring the referential integrity by loading objects in the
correct order
use the glob pattern matching new sequence numbers
use the same glob pattern for sequence number files
- Removes unused CA State Web Template JS
since the test-ui job is used as a PR merge check, we need a PR-related event to trigger the check --> workflow_dispatch doesn't trigger the check https://github.community/t/workflow-dispatch-does-not-update-commit-status/125981/2 so run the job on all PRs to the deploy branches
our code (js, python) is not compiled
Django silently rewrites our static files using a hash of their content enabling longer caching times and better cache busting
we can cache for a long time since Django will rewrite filenames when the contents changes
aws s3 cp doesn't recognize glob/unix file patterns in the path, they can be used with exclude/include flags though https://docs.aws.amazon.com/cli/latest/reference/s3/index.html#use-of-exclude-and-include-filters pattern support is needed to load the new separated fixture files CONFIG_FILE is set in the .env file inside the same AWS_BUCKET
push directly to deploy branches is blocked with protection rules no need to check on PR and push, check runs on PR only
rather than relying on implicit interpretation of the DJANGO_INIT_PATH variable, explicitly list it, then xargs the results into loaddata
github-actions
bot
added
the
deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.