Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Use Bootstrap container, remove article & constricted #133

Merged
merged 2 commits into from
May 17, 2023

Conversation

machikoyasuda
Copy link
Member

closes #123

What this PR does

Removes Article

  • Removes use of <article>.
  • Deletes article CSS.
  • Uses <main class="container"> in default.html layout instead. All pages should now use <section class="row"> and <div class="col-6"> syntax logic.

Removes Constricted

  • Removes use of class="constricted" and replaces it with row/col/justify-center
  • Deletes .constricted CSS.

What this PR does NOT do

  • Refactor out CSS Grid from Footer, Header (to come in Refactor: Navbar header #122), and any other homepage content sections (beyond the "constricted" style)

Screenshots

Removes Article refactor

image Note: This header top issue will be fixed in #122

Removes Constricted refactor

image image

@machikoyasuda machikoyasuda requested a review from a team as a code owner May 17, 2023 18:10
@machikoyasuda machikoyasuda self-assigned this May 17, 2023
@machikoyasuda machikoyasuda added this to the Calitp.org redesign milestone May 17, 2023
@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 8b36996
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/646518a6f8e05d0008dfeda2
😎 Deploy Preview https://deploy-preview-133--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@machikoyasuda
Copy link
Member Author

@thekaveman After this PR is merged, rebase this PR with the latest from staging https://github.com/cal-itp/calitp.org/pull/118/files and the contents of the Press page should be in a container. The Header will still overlap with it until #122 is merged.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly really good!

I think using <section> for everything here is not semantically correct though. From the spec:

The section element is not a generic container element. When an element is needed only for styling purposes or as a convenience for scripting, authors are encouraged to use the div element instead. A general rule is that the section element is appropriate only if the element's contents would be listed explicitly in the document's outline.

The highest-level elements as <section> e.g. <section id="deck">, <section id="details"> seem appropriate, but within those I think <div> might be the better choice.

Thoughts?

@machikoyasuda
Copy link
Member Author

@thekaveman Yeah - having <section>s inside other <section>s doesn't make any sense. I think we should change the children <section>s in subsequent PRs that actually change the contents. This PR is only concerned with the outermost <main> parent (grandparent?).

cc @angela-tran

@angela-tran
Copy link
Member

angela-tran commented May 17, 2023

I agree we should change the inner sections to divs. I'm ok with that being done in separate issues

@machikoyasuda machikoyasuda merged commit 2c39556 into staging May 17, 2023
@machikoyasuda machikoyasuda deleted the refactor/index-article-constricted branch May 17, 2023 21:19
@thekaveman thekaveman mentioned this pull request May 17, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: Remove article padding / use Bootstrap cols
3 participants