-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fix Desktop rhombus bug on Safari #188
Conversation
✅ Deploy Preview for cal-itp-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@segacy1 when you have some time, can you please review this follow-up to the split rhombuses in Mac/Safari -- this time for Desktop widths. (And please ensure no regressions in Mobile as well). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regressions on homepage Contact rhombuses, in Windows/Desktop Firefox and Chrome:
- Bottoms are no longer aligned (seems to only happen in "Tablet" sizes, e.g. less than full-screen but larger than mobile)
- The direction changed and no longer represents the Figma design
Figma
Staging
Bottom of each rhombus is aligned, direction "towards" each other as shown in Figma:
This PR
Bottom of the left rhombus is lower than the bottom of the right rhombus, direction "away" from each other:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Confirmed the fix in Desktop Firefox/Chrome on Windows.
Also, thank you for removing that inline style definition 😁
closes #174 fully
filter: url
entirely, b/c it's very buggy on Safari.How to test
Before & After