Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Initiatives section #215

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fix: Initiatives section #215

merged 1 commit into from
Jul 31, 2023

Conversation

machikoyasuda
Copy link
Member

fix #208

  • hide Mobi Mart button for GTFS, Benefits
  • add pre-button text for Contactless Payments
image image image

@machikoyasuda machikoyasuda added this to the Calitp.org redesign milestone Jul 31, 2023
@machikoyasuda machikoyasuda self-assigned this Jul 31, 2023
@machikoyasuda machikoyasuda requested a review from a team as a code owner July 31, 2023 18:58
@netlify
Copy link

netlify bot commented Jul 31, 2023 •
edited
Loading

✅ Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 9c1cb4b
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/64c8044003249400086c8c39
😎 Deploy Preview https://deploy-preview-215--cal-itp-website.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thekaveman
thekaveman approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally on desktop and mobile views 👍

I like this approach, keeps the data structure more standard and the template logic simpler -- knowing that the button will likely come back at some point.

@machikoyasuda machikoyasuda merged commit 927bec6 into staging Jul 31, 2023
6 checks passed
@machikoyasuda machikoyasuda deleted the feat/208-mobimart-button branch July 31, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
None yet
Projects
Digital Services
Status: Done
Milestone
Calitp.org redesign
Development

Successfully merging this pull request may close these issues.

Update content within Initiatives section to better frame outbound link to MobiMart
2 participants
@machikoyasuda @thekaveman