Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer stories & Partners: New pages and homepage updates #377

Open
wants to merge 85 commits into
base: main
Choose a base branch
from

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jul 24, 2024

closes #351
closes #354
closes #356
closes #382
closes #391

What this PR does

  • Partners page
  • Customer stories page
  • Homepage update

Plan for PR

🚧 🚧 🚧

This PR is not ready for Production - b/c the copy is not final. The code & design are ready for review, but the copy is not. This PR is to be deployed to a branch and that link will be used to get partner approval. Awaiting final copy from CARB.

🚧 🚧 🚧

How to review this PR

  • Run a11y tests on all new pages and homepage
  • Check copy

Test

This preview link has all the new updates: https://deploy-preview-377--cal-itp-website.netlify.app/
https://deploy-preview-377--cal-itp-website.netlify.app/customer-stories
https://deploy-preview-377--cal-itp-website.netlify.app/partners

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 59ed791
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/66ac11ca086eb5000841eb48
😎 Deploy Preview https://deploy-preview-377--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@machikoyasuda machikoyasuda self-assigned this Jul 24, 2024
@machikoyasuda machikoyasuda changed the title Partners Page Partners: Partners page and homepage update Jul 25, 2024
@machikoyasuda machikoyasuda changed the title Partners: Partners page and homepage update Partners: Partners page and homepage logos Jul 25, 2024
@machikoyasuda machikoyasuda reopened this Jul 25, 2024
@machikoyasuda machikoyasuda marked this pull request as ready for review July 25, 2024 19:15
@machikoyasuda machikoyasuda requested review from a team as code owners July 25, 2024 19:15
@machikoyasuda
Copy link
Member Author

@ohmegasquared This is ready for a Design review:

https://deploy-preview-377--cal-itp-website.netlify.app/ - home page logos and new copy
https://deploy-preview-377--cal-itp-website.netlify.app/partners - new page

@ohmegasquared
Copy link

on the home page, I expected the logos to be in the same column width container as the text above
Screenshot 2024-07-25 at 3 24 56 PM
seeing in netlify going outside of that
Screenshot 2024-07-25 at 3 24 51 PM

on mobile they seem to go off screen
Screenshot 2024-07-25 at 3 28 48 PM

Partners looks great!

@machikoyasuda
Copy link
Member Author

@ohmegasquared Ohhhh good catch - thank you! Firefox renders the homepage differently than Chrome and Safari! 🫨
image

@machikoyasuda
Copy link
Member Author

machikoyasuda commented Jul 29, 2024

Ready for re-review @ohmegasquared

on the home page, I expected the logos to be in the same column width container as the text above

Fixed and confirmed in Firefox, Safari, Chrome:
image

@machikoyasuda
Copy link
Member Author

machikoyasuda commented Jul 29, 2024

This PR is now ready for a preliminary PR review for code (@thekaveman @angela-tran or @lalver1) and design (@ohmegasquared). What I want is a comment here that the Partners section is "Approved for design" or "Approved for code." That will give me the permission to stop working on Partners code/design. You do not need to click the GitHub pull request "Approve" button. That will happen after the copy is in and approved as well.

What I plan to do:

  • Monday/Tuesday: Get the Partners PR preliminary approval (code and design).
  • Tuesday/Wednesday: Then, get the Customer Stories PR into this Partners PR preliminary approval (code and design). Once Customer Stories is approved, I'm going to merge Customer Stories into the Partners PR.
  • Wednesday: After the preliminary approvals are done, I don't want to change any code or design. We are code complete. Only copy changes at this point.
  • Wednesday/Thursday: At this point, there will only be 1 PR to manage. In this ONE PR, I'll make all copy/photo changes. Send test URL to @mrose914
  • After that: @mrose914 to communicate final approval to @machikoyasuda, @mrose914 / @thekaveman + one developer approves the PR for reals, then the PR can finally be merged into main and be deployed to prod.

Other notes:

  • Any changes to the current home page, the current home page's Contact section - need to be created as bug tickets. These bug tickets can be worked on separately, and get approved and merged into production immediately.

@ohmegasquared
Copy link

Marissa and I reviewed mobile and web- looks good to us! will make 2 follow up tickets for home dots spacing + footnote adjustment

@lalver1
Copy link
Member

lalver1 commented Jul 30, 2024

This looks great! I viewed the pages locally on Firefox and Safari and I'd say it's approved for code.

@machikoyasuda
Copy link
Member Author

Fix for #382 applied in this PR

@ohmegasquared

@machikoyasuda machikoyasuda linked an issue Jul 31, 2024 that may be closed by this pull request
@ohmegasquared
Copy link

Design is approved on mobile and web! 🔥

@machikoyasuda machikoyasuda changed the title Partners: Partners page and homepage logos Customer stories & Partners: New pages and homepage updates Aug 1, 2024
@machikoyasuda
Copy link
Member Author

New combined PR is here 🎊 🎊

This preview link has all the new updates: https://deploy-preview-377--cal-itp-website.netlify.app/
https://deploy-preview-377--cal-itp-website.netlify.app/customer-stories
https://deploy-preview-377--cal-itp-website.netlify.app/partners

@machikoyasuda
Copy link
Member Author

Update as of Thursday, Aug 1st, 1PM:

  • All copy (including alt tags for images/map on Customer Stories) we have is now in the code.
  • All pages passing WCAG AA.

Open items:

@mrose914 @thekaveman

Copy link

@mrose914 mrose914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more updates:

Copy link

@mrose914 mrose914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-08-01 at 3 55 16 PM

The hyperlink here looks just slightly too big - is that something we can fix? Pretty minor so i'm OK if not, but it looks a little puffy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants