-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customer stories & Partners: New pages and homepage updates #377
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cal-itp-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f2f333b
to
337803e
Compare
@ohmegasquared This is ready for a Design review: https://deploy-preview-377--cal-itp-website.netlify.app/ - home page logos and new copy |
@ohmegasquared Ohhhh good catch - thank you! Firefox renders the homepage differently than Chrome and Safari! 🫨 |
Ready for re-review @ohmegasquared
|
This PR is now ready for a preliminary PR review for code (@thekaveman @angela-tran or @lalver1) and design (@ohmegasquared). What I want is a comment here that the Partners section is "Approved for design" or "Approved for code." That will give me the permission to stop working on Partners code/design. You do not need to click the GitHub pull request "Approve" button. That will happen after the copy is in and approved as well. What I plan to do:
Other notes:
|
Marissa and I reviewed mobile and web- looks good to us! will make 2 follow up tickets for home dots spacing + footnote adjustment |
This looks great! I viewed the pages locally on Firefox and Safari and I'd say it's approved for code. |
Fix for #382 applied in this PR |
Design is approved on mobile and web! 🔥 |
- Sidebar: Adds double sidebar navigation component and logic
New combined PR is here 🎊 🎊 This preview link has all the new updates: https://deploy-preview-377--cal-itp-website.netlify.app/ |
Update as of Thursday, Aug 1st, 1PM:
Open items:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more updates:
- 1.88M Daily transit rides in CA[1] should point to a footnote for a dash that does not yet exist, can leave as Source for now
- 230+ Transit agencies in CA; all can leverage Cal-ITP should link to the Provider Map footnote
- "pre-negotiated MSAs" should link to https://www.camobilitymarketplace.org/contracts/
- 91% Reduction in amount of expired GTFS Schedule Feeds since 2023 - should link to the following source: https://dashboards.calitp.org/public/dashboard/9dd1758e-59de-479a-877b-c63657dc555d?tab=13-objective-1%3A-improve-up-to-dateness-of-schedule-service
- remove (YTD) on Trips stat on homepage and move to footnote so footnote reads "Year to Date, 2024 Cal-ITP Contactless Usage Dashboard ↩"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closes #351
closes #354
closes #356
closes #382
closes #391
What this PR does
Plan for PR
🚧 🚧 🚧
This PR is not ready for Production - b/c the copy is not final. The code & design are ready for review, but the copy is not. This PR is to be deployed to a branch and that link will be used to get partner approval. Awaiting final copy from CARB.
🚧 🚧 🚧
How to review this PR
Test
This preview link has all the new updates: https://deploy-preview-377--cal-itp-website.netlify.app/
https://deploy-preview-377--cal-itp-website.netlify.app/customer-stories
https://deploy-preview-377--cal-itp-website.netlify.app/partners