New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break up daily scheduled service index #2076
Conversation
Thanks @lauriemerrell. Is the idea that this would go into the making of int_gtfs_schedule__daily_scheduled_service_index? |
@owades yes, the idea is that this creates a new |
a3b5a77
to
0d7476c
Compare
0d7476c
to
ff7def0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good.
Description
This PR:
int_gtfs_schedule__long_calendar
to be more useful by expanding to the actual day level & fixes a bug where Sundays were miscodedint_gtfs_schedule__all_scheduled_service
, which will support @owades on add check for proper lead time for schedule updates聽#2047int_gttfs_schedule__daily_scheduled_service_index
: one bug had Sundays miscoded so nocalendar
based Sunday service was appearing, and the other affected cases where a feed used bothcalendar
andcalendar_dates
but had someservice_ids
that were unique tocalendar_dates
TODO:
_index
table accordinglyTest warehouse image per @atvaccaroremoved updates to poetry lockfile because it was causing unrelated issuesResolves # [issue]
Type of change
How has this been tested?
dbt run -s +int_gtfs_schedule__all_scheduled_service+
dbt test -s +int_gtfs_schedule__all_scheduled_service+
Screenshots (optional)