Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action to build/publish Docker image #7

Closed
1 task
thekaveman opened this issue Sep 29, 2021 · 1 comment · Fixed by #22
Closed
1 task

Add GitHub Action to build/publish Docker image #7

thekaveman opened this issue Sep 29, 2021 · 1 comment · Fixed by #22
Assignees
Milestone

Comments

@thekaveman
Copy link
Member

thekaveman commented Sep 29, 2021

Background

The docker-compose.yml over in benefits defines the server service and uses a local build path when the image doesn't yet exist on the machine:

server:
  build: ./server #<-- build the contents of the local ./server directory (which contains a Dockerfile)
  image: eligibility_verification_server:dev

Once the server code is refactored out of that repository and into this one, a local build path won't work anymore.

Proposal

GitHub Container Registry can be used to host Docker images, which can be built and published automatically via GitHub Actions.

  • Set up a publishing workflow for this repository that builds and publishes the server app in a Docker image to GitHub
@machikoyasuda machikoyasuda self-assigned this Oct 4, 2021
@thekaveman thekaveman added this to To do in Benefits 2021 Oct 5, 2021
@machikoyasuda machikoyasuda moved this from Backlog to In progress in Benefits 2021 Oct 5, 2021
@thekaveman
Copy link
Member Author

See cal-itp/calitp-py#17

@machikoyasuda machikoyasuda moved this from In progress to Review in progress in Benefits 2021 Oct 5, 2021
@thekaveman thekaveman added this to the October 2021 milestone Oct 6, 2021
Benefits 2021 automation moved this from Review in progress to Done Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Benefits 2021
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants