-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Action that builds and publishes to GitHub Container Registry #22
Conversation
… the server Docker image to the GitHub container registry on pushes - both regular pushes and releases - to main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great start! I requested some changes that will help us read logs and use the action checks in other contexts later if needed. Made a few other suggestions elsewhere.
…st and with the tag name
Rested this Action in a fork: https://github.com/machikoyasuda/eligibility-server/pull/8 The steps I took:
https://github.com/machikoyasuda/eligibility-server/pkgs/container/eligibility-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
closes #7
part of cal-itp/benefits#127
What this PR does
Build and publish Docker image
What this GitHub Action does:
eligibility-server
Docker image to the GitHub Container Registry, with specific tagsmain
- themain
package is built and updatedmain
, with a$version-tag-name
- the package is built and published with 2 tags: the$version-tag-name
, as well aslatest
main
that touch actual app files (likeeligibility_server/app.py
orrequirements.txt
)How I tested this PR
main
that only edits theREADME.md
: Should not trigger the build and publish workflowmain
that edits a relevant app file: Should trigger a build and publish workflow. A package with the tagtest
should be published: https://github.com/machikoyasuda/eligibility-server/pkgs/container/eligibility-server/8504005?tag=testrelease
: Should trigger a build and publish workflow. A package with the tag with the release name should be published: https://github.com/machikoyasuda/eligibility-server/pkgs/container/eligibility-server