Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic unit tests and unit test running action #16

Merged
merged 9 commits into from
Oct 6, 2021
Merged

Add basic unit tests and unit test running action #16

merged 9 commits into from
Oct 6, 2021

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Oct 1, 2021 •
edited
Loading

closes #15

What this PR does

  • Adds basic unit tests
  • Adds tests/requirements.txt dependencies
  • Adds GitHub action that runs on every pull-request that touches app-related files
  • The GitHub action runs pytest

How to test

  • Testing the tests locally: Run pytest in a Dev Container
  • Testing the GitHub action: The GitHub action runs in this pull request

Base automatically changed from config/linting to main October 4, 2021 19:57
@thekaveman thekaveman added this to In progress in Benefits 2021 Oct 5, 2021
@machikoyasuda machikoyasuda changed the title WIP - Tests/db methods Add tests and test running action Oct 6, 2021
@machikoyasuda machikoyasuda changed the title Add tests and test running action Add basic unit tests and test running action Oct 6, 2021
@machikoyasuda machikoyasuda changed the title Add basic unit tests and test running action Add basic unit tests and unit test running action Oct 6, 2021
@machikoyasuda machikoyasuda marked this pull request as ready for review October 6, 2021 00:25
@thekaveman thekaveman added this to the October 2021 milestone Oct 6, 2021
thekaveman
thekaveman requested changes Oct 6, 2021
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great test coverage for the database. Couple notes on the fixtures.

tests/conftest.py Outdated Show resolved Hide resolved
tests/test_app.py Outdated Show resolved Hide resolved
.github/workflows/run-tests.yml Outdated Show resolved Hide resolved
Benefits 2021 automation moved this from In progress to Review in progress Oct 6, 2021
thekaveman
thekaveman approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖🧪

Benefits 2021 automation moved this from Review in progress to Reviewer approved Oct 6, 2021
@machikoyasuda machikoyasuda merged commit 2719d3d into main Oct 6, 2021
Benefits 2021 automation moved this from Reviewer approved to Done Oct 6, 2021
@machikoyasuda machikoyasuda deleted the tests/db-methods branch October 6, 2021 21:46
@thekaveman thekaveman mentioned this pull request Oct 7, 2021
Closed
@angela-tran angela-tran mentioned this pull request Nov 14, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Benefits 2021
  
Done
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

Add GitHub Action to run pytest for PRs
2 participants
@machikoyasuda @thekaveman