Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calabash run should not expect there to be an 'android' or 'ios' profile #209

Closed
jmoody opened this issue Aug 3, 2015 · 9 comments
Closed
Assignees
Labels
Milestone

Comments

@jmoody
Copy link
Contributor

jmoody commented Aug 3, 2015

I ran into this output:

$ be calabash run ../../spec/resources/android/xtc-android-sample.apk 
Could not find profile: 'android'

Defined profiles in cucumber.yml:
  * app
  * default
  * formatter
  * verbose

This is not a x-platform project.

Do I need to update my support/env.rb and support/hooks.rb? They were generated some time ago.

@TobiasRoikjer
Copy link
Contributor

Yes this is expected behaviour. calabash run uses the profile android or ios

@jmoody
Copy link
Contributor Author

jmoody commented Aug 4, 2015

This doesn't seem right. If the project is not x-platform, android or ios does not make sense.

Does calabash generate allow you to configure this?

@jmoody jmoody added this to the 2.0.0 milestone Dec 10, 2015
@jmoody jmoody changed the title Expected behavior of $ be calabash run ../app.apk calabash run should not expect there to be an 'android' or 'ios' profile Dec 10, 2015
@TobiasRoikjer
Copy link
Contributor

@jmoody I consider this expected behaviour and not a bug. Have you changed your opinion?

@jmoody jmoody assigned krukow and unassigned TobiasRoikjer Dec 11, 2015
@jmoody
Copy link
Contributor Author

jmoody commented Dec 11, 2015

I don't think this is the correct behavior. Assigning to Karl for a decision.

@krukow
Copy link
Contributor

krukow commented Dec 14, 2015

I need more information to decide this. Let's discuss offline.

@krukow
Copy link
Contributor

krukow commented Dec 14, 2015

@jmoody @TobiasRoikjer ^

@TobiasRoikjer
Copy link
Contributor

@jmoody If you generate skeletons using a newer version this is expected behaviour. You are right that this might be unexpected when you are targeting only one platform, but that means you have created your own hooks and env instead of basing them on the default generated ones.

A user can always just run using cucumber.

I am not certain this is the best approach, and I can be convinced to change this behaviour

@krukow
Copy link
Contributor

krukow commented Dec 17, 2015

@jmoody @TobiasRoikjer I don't think we should require profiles of specific names. What we should require is that certain configuration is called so that either iOS or Android is configured - does that make sense.

@TobiasRoikjer
Copy link
Contributor

The run command is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants