Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Public interface for TCC.db #391

Closed
wants to merge 6 commits into from
Closed

Conversation

jmoody
Copy link
Member

@jmoody jmoody commented Mar 4, 2016

REBASED Mon Aug 29 19:54 CET

WIP Based on my work with Permissions TCC, this needs some TLC before merging.

Motivation

Progress on Setting the simulator privacy settings is broken in Xcode 6 #525

Public API

RunLoop::TCC.services
RunLoop::TCC.allow(device, app, services)
RunLoop::TCC.deny(device, app, services)

$ run-loop tcc services
$ run-loop tcc allow --app [OPTIONS]
$ run-loop tcc deny --app [OPTIONS]

@jmoody
Copy link
Member Author

jmoody commented Mar 4, 2016

@TobiasRoikjer Please review. It is a big PR, but a complete feature.

I am most interested in feedback about the public API: 1c8015e

This is a reimplementation of calabash-ios/launcher.rb TCC code

@jmoody
Copy link
Member Author

jmoody commented Mar 8, 2016

@krukow Can you review? I would like to release this so it can be available in Calabash 0.18.2.

@jmoody jmoody modified the milestone: 2.0.8 Mar 8, 2016
@jmoody
Copy link
Member Author

jmoody commented Mar 8, 2016

Moving out of the feature set for 0.18.2.

@jmoody
Copy link
Member Author

jmoody commented Mar 10, 2016

This feature will not be merged because we have no way of performing the same operation on physical devices.

@bootstraponline
Copy link

bootstraponline commented Jul 12, 2016

This feature is pretty cool. Is there no place for simulator only features in calabash? I ended up forking run_loop and restoring TCC.db support.

@jmoody
Copy link
Member Author

jmoody commented Aug 28, 2016

@bootstraponline I agree that this is a cool feature. I am trying to find support for merging it.

@jmoody jmoody reopened this Aug 29, 2016
@jmoody jmoody force-pushed the feature/interface-to-tcc.db branch from 1c8015e to 96e5dde Compare August 29, 2016 17:53
@jmoody
Copy link
Member Author

jmoody commented Aug 29, 2016

REBASED Mon Aug 29 19:54 CET

Reviving. At the very least, I want this as gem maintainer.

@bootstraponline
Copy link

I also approve this feature. Testing on the simulator is way easier with TCC.db modifications. I made two changes from upstream:

If the revival is successful, it'd be nice to have a way to get these improvements into upstream.

@jmoody
Copy link
Member Author

jmoody commented Aug 29, 2016

@bootstraponline

bundle id

Yeah. I am probably going add an :all keyword to deny/allow all services.

I saw the keyboard settings, but I am not sure I understand the value. I can be convinced.

I noticed you were using CFPropertyList (IIRC). We are trying to remove that gem from the stack. It has (at least in the past) not written BOOL type values correctly.

@bootstraponline
Copy link

I noticed you were using CFPropertyList (IIRC). We are trying to remove that gem from the stack. It has (at least in the past) not written BOOL type values correctly.

Ouch. I'll migrate over to whatever the replacement ends up being then.

I saw the keyboard settings, but I am not sure I understand the value. I can be convinced.

What do you think about allowing users to specify their own keyboard settings? Right now it looks like there's just a hard coded set of options. I'm trying to match the Facebook configuration so the existing default doesn't work for me.

Yeah. I am probably going add an :all keyword to deny/allow all services.

Cool.

@jmoody
Copy link
Member Author

jmoody commented Aug 29, 2016

allow/deny all

Huh. Already exists. Just pass an empty array or no array at all. I will have to check the command line interface.

CFPropertyList

We shell out to /usr/libexec/PlistBuddy. :/

Keyboard

I will look at what you have again. Probably no changes until after the iOS 10 dust settles.

@bootstraponline
Copy link

allow/deny all
Huh. Already exists. Just pass an empty array or no array at all. I will have to check the command line interface.

I think you're misunderstanding the code. The bundle id changes allow configuring apps that don't exist (meaning there is no .app path, only a bundle id).

@jmoody
Copy link
Member Author

jmoody commented Aug 29, 2016

bundle id

I want to support RunLoop::App instances, paths, and bundle ids. :)

@bootstraponline
Copy link

Agreed. :)

On Mon, Aug 29, 2016, 6:49 PM Joshua Moody notifications@github.com wrote:

bundle id

I want to support RunLoop::App instances, paths, and bundle ids. :)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#391 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHmQYCZOD3O4tjjEH03ht-QP0DQC8tAks5qk2HlgaJpZM4HpksQ
.

jmoody added a commit to calabash/Permissions that referenced this pull request Sep 9, 2016
Someday I will get this feature in run_loop

calabash/run_loop#391
@jmoody jmoody changed the title Public interface for TCC.db WIP Public interface for TCC.db Sep 19, 2016
@bootstraponline
Copy link

Does this approach work for location and push permissions?

@jmoody
Copy link
Member Author

jmoody commented Nov 25, 2016

It does not work for location or APNS permissions.

@krukow krukow removed their assignment Feb 22, 2017
@bootstraponline
Copy link

any update on this? 😄

@bootstraponline
Copy link

bootstraponline commented Mar 10, 2017

It does not work for location or APNS permissions.

I added location support

I also figured out how to get notification permission, you just copy over data/Library/BulletinBoard/SectionInfo.plist after authorizing the app once.

@bootstraponline
Copy link

I'm guessing that since calabash is EOL, run_loop won't be getting any new features?

@jmoody
Copy link
Member Author

jmoody commented Apr 21, 2017

I'm guessing that since calabash is EOL, run_loop won't be getting any new features?

That is a safe assumption.

I could not get traction for this feature because it only worked on simulators.

@IlyaBausovAkvelon IlyaBausovAkvelon deleted the feature/interface-to-tcc.db branch September 2, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants