You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, we're sorting against the ISO language name (e.g. Russian) but displaying the endonym aka native language name (e.g. русский), but we're also doing the strange thing of making American English the default, which puts it at the top of the list:
Two things would improve this:
I propose that we keep the default within the sorting (so American English would appear above British English).
Within an IRC discussion, @adriaandegroot also suggested adding the ISO language names with the endonym so we have something like "русский (Russian)" or "Russian (русский)" (I prefer the latter since this is what we're sorting on).
Regarding that former item, the suggestions made were:
dropping the special case in LocaleItem::operator <
just selecting US English at its correct spot in the drop-down
Regarding the latter, there was concern expressed about getting QComboBox to display like that. @kkofler suggested:
a custom item delegate QComboBox::setItemDelegate
store the ISO language name in the userData of the item and have the item delegate paint it
There's a downstream bug concerning the apparent "randomness" of the list. Upon further inspection, that's clearly not the case and so I closed it, but these two changes would make a significant impact on removing any concern at all.
The text was updated successfully, but these errors were encountered:
wxl
changed the title
welcome module language list: fix sorting, display endonym and ISO name, put American English where it belongs
welcome module language list: display endonym and ISO name, put American English in proper sort location
Mar 4, 2019
Right now, we're sorting against the ISO language name (e.g. Russian) but displaying the endonym aka native language name (e.g. русский), but we're also doing the strange thing of making American English the default, which puts it at the top of the list:
Two things would improve this:
Regarding that former item, the suggestions made were:
LocaleItem::operator <
Regarding the latter, there was concern expressed about getting
QComboBox
to display like that. @kkofler suggested:QComboBox::setItemDelegate
userData
of the item and have the item delegate paint itThere's a downstream bug concerning the apparent "randomness" of the list. Upon further inspection, that's clearly not the case and so I closed it, but these two changes would make a significant impact on removing any concern at all.
The text was updated successfully, but these errors were encountered: