Alert Plugin uses a better pattern to manage callback handle id #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is used from plugin registry for all plugin callbacks and plugin callbacks are sort of async after first call to 'call' method in a plugin, it's important that callbackHandle lives in intent that an instance varaible of class; as the latter can potentially be overridden.
vivekjain10
added a commit
that referenced
this pull request
Aug 17, 2013
Alert Plugin uses a better pattern to manage callback handle id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the way we manage the callback handle id. Since same instance is used from plugin registry for all plugin callbacks and plugin callbacks are sort of async after first call to 'call' method in a plugin, it's important that callbackHandle lives in intent that an instance variable of class; as the latter can potentially be overridden.