This repository has been archived by the owner on May 16, 2023. It is now read-only.
Use serde_dynamo for dynamodb::Event items (#140)
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `serde_dynamo::Item` instead of `HashMap<String, AttributeValue>` to represent the `keys`, `old_image`, and `new_image` in a `dynamodb::Event`. This consolidates the Rust/DynamoDB ecosystem around fewer representations of DynamoDB items. Note that `serde_dynamo::AttributeValue` and `aws_lambda_events::dynamodb::attributes::AttributeValue` are slightly different (especially with regards to the `Number` enumeration) so this is a breaking change that would either need to go behind a feature flag or a major version bump. (cherry picked from commit 50ce8ed) Signed-off-by: David Calavera <david.calavera@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking this commit into the right branch.
(cherry picked from commit 50ce8ed)
Signed-off-by: David Calavera david.calavera@gmail.com