This repository has been archived by the owner on May 16, 2023. It is now read-only.
fix(sns): Properly handle non-required fields, and correct casing. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Subject` and `MessageAttributes` may be completely missing from the payload. Additionally `SigningCertURL` and `UnsubscribeURL` have fully capitalized `URL` unlike default renaming from serde of `Url`. Examples for reference from the official .NET SDK. https://github.com/aws/aws-sdk-net/blob/475822dec5e87954b7a47ac65995714ae1f1b115/sdk/test/Services/SimpleNotificationService/UnitTests/Custom/SNSMessageUtilityTests.cs#L26-L38 https://github.com/aws/aws-sdk-net/blob/449bb72eccfe78c2bfbd8ee2edbc2a7225e8323b/sdk/src/Services/SimpleNotificationService/Custom/Util/Message.cs#L73-L84
calavera
approved these changes
May 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubjectandMessageAttributesmay be completely missing from the payload.Additionally
SigningCertURLandUnsubscribeURLhave fully capitalizedURLunlike default renaming from serde ofUrl.Examples for reference from the official .NET SDK.
https://github.com/aws/aws-sdk-net/blob/475822dec5e87954b7a47ac65995714ae1f1b115/sdk/test/Services/SimpleNotificationService/UnitTests/Custom/SNSMessageUtilityTests.cs#L26-L38
https://github.com/aws/aws-sdk-net/blob/449bb72eccfe78c2bfbd8ee2edbc2a7225e8323b/sdk/src/Services/SimpleNotificationService/Custom/Util/Message.cs#L73-L84