New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate build target for AWS Lambda, and check target component in toolchain #39
feat: validate build target for AWS Lambda, and check target component in toolchain #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good @rnag !
Awesome, am glad to hear it! I went ahead and marked this PR as open for review in that case. I also marked the one test as ignored since it's technically an integration test, and ideally might want to skip running it on CI when using |
I don't understand why the workflows didn't run 🤔 |
…into feature-check-target-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, I have no idea why GitHub doesn't give me the option to trigger the workflows for your PR. I'll run some tests locally and I'll merge it if everything looks good on my end.
FYI, you removed the |
|
I reverted changes and moved the |
Thanks @rnag, I'll run local tests again this evening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great now, thanks @rnag !
I'll release a new minor version this weekend with this new feature. Thanks a lot for your help 🤘
Hi @calavera, just creating this as a draft PR for you to review when you have time; hopefully this resolves #30.
I've also added a test for adding the target component to the toolchain, and confirmed it works as expected. It looks like the check to confirm if a target component is present in the toolchain should be "zero cost", as it involves just a lookup to see if a directory exists or not in the rustup home.
--
Below are the changes added as part of this feature:
--target
is currently supported for deployments to AWS Lambdarustup target add <component>
if needed