Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore glibc version in --target for checks #44

Merged

Conversation

rnag
Copy link
Contributor

@rnag rnag commented Mar 31, 2022

I found a minor bug when doing local testing with a cargo install --path . approach: if I pass a target along with glibc version like x86_64-unknown-linux-musl.2.17, it tries to install the target component as it includes glibc part when checking if it's installed in the toolchain. Ideally, it should exclude the part after . in the final target which we run checks against.

These changes should fix following issues:

  • when determining same target as host, use starts_with instead, in case --target has a trailing glibc part
  • when checking if target is installed in toolchain, use the target name before the ., so we can omit the glibc part in the check

@rnag rnag changed the title ignore glibc version in --target for checks fix: ignore glibc version in --target for checks Mar 31, 2022
@calavera calavera merged commit c66ba01 into cargo-lambda:main Mar 31, 2022
@mbergkvist
Copy link
Contributor

Will there be a 0.5.2 release with this?

@calavera
Copy link
Collaborator

calavera commented Apr 1, 2022

@mbergkvist yes, probably today or tomorrow. I'll leave a comment in this thread when it's done

@calavera
Copy link
Collaborator

calavera commented Apr 1, 2022

@mbergkvist released https://crates.io/crates/cargo-lambda/0.5.2

@mbergkvist
Copy link
Contributor

Thanks!

@rnag rnag deleted the fix-ignore-glibc-version-in-final-target branch April 2, 2022 17:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants