fix: ignore glibc version in --target
for checks
#44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a minor bug when doing local testing with a
cargo install --path .
approach: if I pass a target along with glibc version likex86_64-unknown-linux-musl.2.17
, it tries to install the target component as it includes glibc part when checking if it's installed in the toolchain. Ideally, it should exclude the part after.
in the final target which we run checks against.These changes should fix following issues:
starts_with
instead, in case--target
has a trailing glibc part.
, so we can omit the glibc part in the check