Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Response.php #924

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Update Response.php #924

merged 1 commit into from
Jul 19, 2024

Conversation

gurubobnz
Copy link
Contributor

Ignore pagination element in response, proposed fix for #923

Ignore pagination element in response.
@oatmael
Copy link

oatmael commented Jul 22, 2024

@calcinai this change was also made in #918 :
https://github.com/calcinai/xero-php/pull/918/files#diff-d7be814166ab8f10b0e0f81580d74f84450e12e1cb79fd7b627d536b2572c33cR321

so there's now duplicate cases in the switch cases:
https://github.com/calcinai/xero-php/blob/master/src/XeroPHP/Remote/Response.php#L324

thankfully this functionally doesn't matter, but try and keep in mind for future :)

@calcinai
Copy link
Owner

Gosh my bad. It'll just break at the first, but I'll tidy up for next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants