Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-3377] Issue with stripe meta data corrupts many different endpoints #14482

Closed
keithwillcode opened this issue Apr 9, 2024 · 4 comments · Fixed by #14549
Closed

[CAL-3377] Issue with stripe meta data corrupts many different endpoints #14482

keithwillcode opened this issue Apr 9, 2024 · 4 comments · Fixed by #14549
Assignees
Labels
billing area: billing, stripe, payments, paypal, get paid 🐛 bug Something isn't working consumer High priority Created by Linear-GitHub Sync
Milestone

Comments

@keithwillcode
Copy link
Contributor

[ { "code": "invalid_type", "expected": "string", "received": "undefined", "path": [ "apps", "stripe", "currency" ], "message": "Required" } ]

Go to Sentry to see all the places it's affecting

From SyncLinear.com | CAL-3377

@keithwillcode keithwillcode added consumer High priority Created by Linear-GitHub Sync labels Apr 9, 2024
@dosubot dosubot bot added billing area: billing, stripe, payments, paypal, get paid platform Anything related to our platform plan 🐛 bug Something isn't working labels Apr 9, 2024
@keithwillcode
Copy link
Contributor Author

SomethingWentWrong.png

@keithwillcode keithwillcode added this to the v4.0 milestone Apr 9, 2024
@keithwillcode keithwillcode added consumer and removed platform Anything related to our platform plan consumer labels Apr 9, 2024
@SkipDead
Copy link

SkipDead commented Apr 9, 2024

Possible way to reproduce the bug :

Two last actions I did :

  1. I was trying to remove Stripe app from my account app. It did not work because I got a Bad Request error on the remove app button click.
  2. I had another window (my website) and I was on the confirmation summary step. I clicked on the cancel button and confirmed it after being prompted to write a reason to cancel.

Current observed behavior :

integration on website
I receive an error 500 when trying to display on my website any Event :
image

behaviors on the cal dashboard
On the dashboard of cal, I cannot access my Event.

Payload on https://app.cal.com/api/trpc/eventTypes/getByViewer? call when I look at the console :

[
    {
        "error": {
            "json": {
                "message": "[\n  {\n    \"code\": \"invalid_type\",\n    \"expected\": \"string\",\n    \"received\": \"undefined\",\n    \"path\": [\n      \"apps\",\n      \"stripe\",\n      \"currency\"\n    ],\n    \"message\": \"Required\"\n  }\n]",
                "code": -32603,
                "data": {
                    "code": "INTERNAL_SERVER_ERROR",
                    "httpStatus": 500,
                    "path": "getByViewer"
                }
            }
        }
    }
]

It looks like a validation error related to stripe possibly because of the payload ? My honest take is that for some reasons, the currency selected for a stripe payment got emptied for an unkown reason. I can visually see the error on the cancelled booking tab :
image

but on the others tabs shows that I have no booking. It is obivously because of the same error 500. Would say the same for the event Type page.

@sean-brydon
Copy link
Member

Context: Me and @emrysal are doing some digging on this - we see this on the update event type and think its an issue with dirty fields.

We are also seeing this in another few places which are looking into right now - eventType viewer

@SkipDead
Copy link

Ok thank you for the follow up.

Also, I would recommend some kind of validation / catching when a a specific event type has a problem with its schema.

For example, I would see the error for a specific event without affecting the whole page / system.

If I have 2 event type but one of them does not pass the validation, the system could show the error only for that event type but will show the second event type regardless.

Will make the system more robust and not lock the account because of one invalid event type. I am not familiar with the architecture of cal so I am not sure if this check is possible to do. But it would be interesting as it seems that it is affecting the whole booking feature page and the event type page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
billing area: billing, stripe, payments, paypal, get paid 🐛 bug Something isn't working consumer High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants