-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAL-3377] Issue with stripe meta data corrupts many different endpoints #14482
Comments
Possible way to reproduce the bug : Two last actions I did :
Current observed behavior : integration on website behaviors on the cal dashboard Payload on https://app.cal.com/api/trpc/eventTypes/getByViewer? call when I look at the console : [
{
"error": {
"json": {
"message": "[\n {\n \"code\": \"invalid_type\",\n \"expected\": \"string\",\n \"received\": \"undefined\",\n \"path\": [\n \"apps\",\n \"stripe\",\n \"currency\"\n ],\n \"message\": \"Required\"\n }\n]",
"code": -32603,
"data": {
"code": "INTERNAL_SERVER_ERROR",
"httpStatus": 500,
"path": "getByViewer"
}
}
}
}
] It looks like a validation error related to stripe possibly because of the payload ? My honest take is that for some reasons, the currency selected for a stripe payment got emptied for an unkown reason. I can visually see the error on the cancelled booking tab : but on the others tabs shows that I have no booking. It is obivously because of the same error 500. Would say the same for the event Type page. |
Context: Me and @emrysal are doing some digging on this - we see this on the update event type and think its an issue with dirty fields. We are also seeing this in another few places which are looking into right now - eventType viewer |
Ok thank you for the follow up. Also, I would recommend some kind of validation / catching when a a specific event type has a problem with its schema. For example, I would see the error for a specific event without affecting the whole page / system. If I have 2 event type but one of them does not pass the validation, the system could show the error only for that event type but will show the second event type regardless. Will make the system more robust and not lock the account because of one invalid event type. I am not familiar with the architecture of cal so I am not sure if this check is possible to do. But it would be interesting as it seems that it is affecting the whole booking feature page and the event type page. |
[ { "code": "invalid_type", "expected": "string", "received": "undefined", "path": [ "apps", "stripe", "currency" ], "message": "Required" } ]
Go to Sentry to see all the places it's affecting
From SyncLinear.com | CAL-3377
The text was updated successfully, but these errors were encountered: