fix: Remove hardcoded stripe.. #14549
Merged
+4
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (04/12/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (04/12/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 310 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/12/2024 02:32:01pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 5b11eec Started: 04/12/2024 02:28:36pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule for booking with seats If rescheduled/cancelled booking with seats it should display the correct number of seats
Retry 2 • Retry 1 • Initial Attempt |
0.61% (2)2 / 328 runsfailed over last 7 days |
4.57% (15)15 / 328 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
0% (0)0 / 317 runsfailed over last 7 days |
17.35% (55)55 / 317 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
4.76% (15)15 / 315 runsfailed over last 7 days |
26.03% (82)82 / 315 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 324 runsfailed over last 7 days |
39.81% (129)129 / 324 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt |
2.77% (9)9 / 325 runsfailed over last 7 days |
34.77% (113)113 / 325 runsflaked over last 7 days |
📄 apps/web/playwright/bookings-list.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Bookings Upcoming bookings managed eventType booking should be visible to team admin
Retry 1 • Initial Attempt |
7.41% (8)8 / 108 runsfailed over last 7 days |
21.30% (23)23 / 108 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.62% (2)2 / 324 runsfailed over last 7 days |
52.78% (171)171 / 324 runsflaked over last 7 days |
emrysal
deleted the
bugfix/14482-remove-payment-metadata-on-deleteCredential
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes whenever any payment app credential was deleted, if there was an installed payment app of any type on an event type, it would add stripe incorrectly to the event type and brick the user.
Fixes: #14482
Fixes CAL-3377
This created invalid data in our database, like:
Instead, the right behaviour should be to remove the deletedCredential from the eventType(s) in it's entirety, no reason to keep historical data. For now we keep the
hiddenbehaviour; however this should be reevaluated @PeerRichNeeds (but it's quite urgent):