Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BR] No min-max value in place for StartTime and EndTime in "Change available time" #687

Closed
SBagaria2710 opened this issue Sep 18, 2021 · 2 comments
Labels
🐛 bug Something isn't working ❗️invalid This doesn't seem right

Comments

@SBagaria2710
Copy link

Issue Summary

No min-max set for StartTime and EndTime. Users are able to set time slots outside the range of 24 hour system.
Please, refer the screenshot attached.

Screenshot 2021-09-18 at 9 55 23 PM

Notice at the text: Currently, your day is set to start at 30:00 and end at 25:00

Steps to Reproduce

  1. Went to https://app.cal.com/availability
  2. Clicked on Change available times
  3. Set the StartTime and EndTime to any number.

Same can be reproduced on the local app as well.

Even though, users are not given the option to choose in between 12 hour system and 24 hour system, users should be checked for entering the wrong time. It might a mistake from user end, but it shouldn't have happened.

Since, we are not handling this StartTime can be greater than EndTime. Which again doesn't make much sense.

Technical details

  • Browser version: Chrome 93
  • Node.js version - v14.17.6
@SBagaria2710
Copy link
Author

SBagaria2710 commented Sep 18, 2021

I'd like to fix this issue if you guys allow me 🙇🏼

@PeerRich @baileypumfleet @femyeda

@SBagaria2710 SBagaria2710 changed the title No min-max value in place for StartTime and EndTime in "Change available time" [Bug Report] No min-max value in place for StartTime and EndTime in "Change available time" Sep 18, 2021
@SBagaria2710 SBagaria2710 changed the title [Bug Report] No min-max value in place for StartTime and EndTime in "Change available time" [BR] No min-max value in place for StartTime and EndTime in "Change available time" Sep 18, 2021
@ConnorGargano ConnorGargano added ❗️invalid This doesn't seem right 🐛 bug Something isn't working labels Oct 22, 2021
@emrysal
Copy link
Contributor

emrysal commented Dec 18, 2021

Having implemented the new /availability edit page; this is now fixed as the old start and endtimes are deprecated. 👍

@emrysal emrysal closed this as completed Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ❗️invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants