Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First Day of the Week Not Corresponding to Settings #781

Closed
marvinvonhagen opened this issue Sep 25, 2021 · 4 comments
Closed

First Day of the Week Not Corresponding to Settings #781

marvinvonhagen opened this issue Sep 25, 2021 · 4 comments

Comments

@marvinvonhagen
Copy link

Issue Summary

First Day of the week on the booking page doesn't correspond to Settings

Steps to Reproduce

  1. Go to Settings → Profile
  2. Set "First Day of the Week" to "Monday"

Still, when going to the booking page, Sunday is shown as the first day of the week. Would be great if the booking page would stick to the setting in the settings, or, even better, adapt to the current region/setting of the person booking!

Details

  • Location: France
@maschmann
Copy link

maschmann commented Sep 27, 2021

Same goes for me.
As it seems, the value is never used as a param for the calendar - or I was too stupid to read the code of the AvailabilityPage.tsx where the initialization is always done with "Sunday", hardcoded.

If someone could point me in the right direction, I'd try to fix this ;-)

One other thing that does not end up in the datepicker are the business days. Per default Sat/Sun are bookable, if not blocked by calendar entries.

@ConnorGargano
Copy link

Hi @marvinvonhagen,
I will see if this is a current issue and the engineering team is aware of this.
-Thanks Connor

@ConnorGargano
Copy link

Hi @maschmann,
I have tested this and it looks like this is now working. I will close the issue and if the error is still occurring please let me know.
-Thanks Connor

@maschmann
Copy link

Hi @ConnorGargano you mean "now working" as in current main branch?
So, when does this end up in a release? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants