-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add password checks for password-reset #10042
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Thank you for following the naming conventions! 🙏 |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 127 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/10/2023 07:11:28pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: ea784e3 Started: 07/10/2023 07:09:00pm UTC
|
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Popup Tests -- new-booker should be able to reschedule
Retry 1 • Initial Attempt |
15.69% (32)32 / 204 runsfailed over last 7 days |
83.33% (170)170 / 204 runsflaked over last 7 days |
Popup Tests -- old-booker should be able to reschedule
Retry 1 • Initial Attempt |
4.98% (10)10 / 201 runsfailed over last 7 days |
74.13% (149)149 / 201 runsflaked over last 7 days |
@sean-brydon could you take a look at the failed e2e tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking to made some adjustments. We can drop useState in the form. Also we don't mark a password request as already used in the API which allows to reuse the same URL to reset the password multiple times.
EDIT:
We need to updates e2e tests as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Got rid of extra state in favor of form state
- Added request expiration after being used
- Updated test to match new password policy
Co-authored-by: zomars <zomars@me.com>
What does this PR do?
for some reason forgot password-reset page lost its validation to check password validity
How to test: