Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add password checks for password-reset #10042

Merged
merged 6 commits into from
Jul 10, 2023
Merged

Conversation

sean-brydon
Copy link
Member

What does this PR do?

for some reason forgot password-reset page lost its validation to check password validity
CleanShot 2023-07-10 at 17 41 33@2x
CleanShot 2023-07-10 at 17 41 37@2x
CleanShot 2023-07-10 at 17 41 41@2x
CleanShot 2023-07-10 at 17 42 04@2x

How to test:

  • Invalid password -> Error
  • Valid password -> success

@vercel
Copy link

vercel bot commented Jul 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:22pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:22pm
cal-staging 🔄 Building (Inspect) Mar 19, 2024 3:22pm
ui ❌ Failed (Inspect) Mar 19, 2024 3:22pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
dev ⬜️ Ignored (Inspect) Mar 19, 2024 3:22pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/auth/forgot-password/[id] 159.49 KB 313.13 KB 89.47% (🟢 -0.20%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link

deploysentinel bot commented Jul 10, 2023

Current Playwright Test Results Summary

✅ 127 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/10/2023 07:11:28pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: ea784e3

Started: 07/10/2023 07:09:00pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests -- new-booker should be able to reschedule
Retry 1Initial Attempt
15.69% (32) 32 / 204 runs
failed over last 7 days
83.33% (170) 170 / 204 runs
flaked over last 7 days
Popup Tests -- old-booker should be able to reschedule
Retry 1Initial Attempt
4.98% (10) 10 / 201 runs
failed over last 7 days
74.13% (149) 149 / 201 runs
flaked over last 7 days

View Detailed Build Results


@CarinaWolli
Copy link
Member

@sean-brydon could you take a look at the failed e2e tests?

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking to made some adjustments. We can drop useState in the form. Also we don't mark a password request as already used in the API which allows to reuse the same URL to reset the password multiple times.

EDIT:

We need to updates e2e tests as well.

zomars
zomars previously approved these changes Jul 10, 2023
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Got rid of extra state in favor of form state
  • Added request expiration after being used
  • Updated test to match new password policy

@zomars zomars merged commit e83647c into main Jul 10, 2023
28 of 30 checks passed
@zomars zomars deleted the feat/password-reset-page branch July 10, 2023 19:13
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants