Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slot reservation uses wrong event length #10103

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

CarinaWolli
Copy link
Member

@CarinaWolli CarinaWolli commented Jul 12, 2023

What does this PR do?

Fixes that for events with multiple duration, the slot reservation system uses the wrong event length to reserve slots.

Requirement/Documentation

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • create event type with multiple durations choose 15 min and 120 min
  • make 120 min the default duration
  • go to the event type link
  • pick any 15min slot (for example 11:00-11:15) => this slot is reserved now
  • Open a new browser tab with the event-type link
  • check available slots for 15 min duration at the day you booked the event:
    • expected slots: all slots except 11:00 should be here
    • before: all slots between 9:00 and 11:00 were missing

@CarinaWolli CarinaWolli requested a review from a team July 12, 2023 17:44
@vercel
Copy link

vercel bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
api ✅ Ready (Inspect) Visit Preview Jul 12, 2023 5:44pm
cal ✅ Ready (Inspect) Visit Preview Jul 12, 2023 5:44pm
ui ✅ Ready (Inspect) Visit Preview Jul 12, 2023 5:44pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

Thank you for following the naming conventions! 🙏

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Jul 12, 2023

🤖 Meticulous spotted visual differences in 71 of 155 screens tested: view and approve differences detected.

Last updated for commit 317651d. This comment will update as new commits are pushed.

@zomars zomars added the core area: core, team members only label Jul 12, 2023
@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zomars zomars merged commit 8812580 into main Jul 12, 2023
32 of 33 checks passed
@zomars zomars deleted the fix/reserved-slots-multi-duration-event branch July 12, 2023 19:06
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants