fix: Remove/Update behaviour of date-overrides #10116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
🤖 Meticulous spotted visual differences in 73 of 208 screens tested: view and approve differences detected. Last updated for commit f96c641. This comment will update as new commits are pushed. |
|
Thank you for following the naming conventions! 🙏 |
emrysal
added
High priority
Current Playwright Test Results Summary✅ 88 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/13/2023 12:13:35am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f96c641 Started: 07/13/2023 12:12:00am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
2.27% (1)1 / 44 runfailed over last 7 days |
97.73% (43)43 / 44 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1 • Initial Attempt |
3.03% (6)6 / 198 runsfailed over last 7 days |
40.91% (81)81 / 198 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 1 • Initial Attempt |
0.67% (2)2 / 297 runsfailed over last 7 days |
10.44% (31)31 / 297 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
zomars
deleted the
bugfix/fix-replace-and-delete-behaviour-date-overrides
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is not the cleanest approach, but the existing mechanism didn't work in a few situations because of the date sort. The update caused a re-render that caused an invalid unsortedFieldArrayMap.
Reproduction/how to test:
Updating bug was hit when you changed the date and it went before another date (re-ordering); which then modified the wrong date override. This PR replaces the entire array which retains the correct sort order by brute force.
Delete bug was encountered if the sorted order was not the same as the filtered order, which depends on the order you created the date overrides in. This PR implements an original order before the sort causing the right item to be removed.
Fixes #8043