feat: remove location modal in event setup #11796

Udit-takkar · 2023-10-10T15:07:56Z

What does this PR do?

I used useFieldArray (https://react-hook-form.com/docs/usefieldarray) for handling locations in event setup page instead of creating another form like before which was very complex.

Screen.Recording.2023-10-18.at.8.56.41.PM.mov

How to test?

Go to any event type page
Add location in the event setup tab

Type of change

Chore (refactoring code, technical debt, workflow improvements)
New feature (non-breaking change which adds functionality)

vercel · 2023-10-10T15:08:07Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2023 0:26am
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2023 0:26am
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2023 0:26am
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2023 0:26am
qa	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2023 0:26am
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2023 0:26am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Oct 24, 2023 0:26am

github-actions · 2023-10-10T15:08:19Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

github-actions · 2023-10-10T15:19:39Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/event-types/[type]`	`415.61 KB`	571.68 KB	163.34% (🟡 +7.62%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

deploysentinel · 2023-10-10T15:19:50Z

Current Playwright Test Results Summary

✅ 197 Passing - ⚠️ 18 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/24/2023 12:23:19pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 158035c

Started: 10/24/2023 12:19:15pm UTC

⚠️ Flakes

📄 apps/web/playwright/locale.e2e.ts • 13 Flakes

Top 1 Common Error Messages

`null`	13 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
unauthorized user sees correct translations (de) should use correct translations and html attributes Retry 1 • Initial Attempt	-15.85% (-45) -45 / 284 runs failed over last 7 days	16.20% (46) 46 / 284 runs flaked over last 7 days
unauthorized user sees correct translations (ar) should use correct translations and html attributes Retry 1 • Initial Attempt	-16.25% (-46) -46 / 283 runs failed over last 7 days	16.25% (46) 46 / 283 runs flaked over last 7 days
unauthorized user sees correct translations (zh) should use correct translations and html attributes Retry 1 • Initial Attempt	-13.93% (-39) -39 / 280 runs failed over last 7 days	14.29% (40) 40 / 280 runs flaked over last 7 days
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes Retry 1 • Initial Attempt	-14.34% (-40) -40 / 279 runs failed over last 7 days	14.34% (40) 40 / 279 runs flaked over last 7 days
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes Retry 1 • Initial Attempt	-14.34% (-40) -40 / 279 runs failed over last 7 days	14.34% (40) 40 / 279 runs flaked over last 7 days
unauthorized user sees correct translations (pt) should use correct translations and html attributes Retry 1 • Initial Attempt	-14.34% (-40) -40 / 279 runs failed over last 7 days	14.34% (40) 40 / 279 runs flaked over last 7 days
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes Retry 1 • Initial Attempt	-13.26% (-37) -37 / 279 runs failed over last 7 days	13.62% (38) 38 / 279 runs flaked over last 7 days
unauthorized user sees correct translations (es-419) should use correct translations and html attributes Retry 1 • Initial Attempt	-13.31% (-37) -37 / 278 runs failed over last 7 days	13.67% (38) 38 / 278 runs flaked over last 7 days
authorized user sees correct translations (de) should return correct translations and html attributes Retry 1 • Initial Attempt	-10.83% (-30) -30 / 277 runs failed over last 7 days	13.72% (38) 38 / 277 runs flaked over last 7 days
authorized user sees correct translations (pt-br) should return correct translations and html attributes Retry 1 • Initial Attempt	-11.57% (-31) -31 / 268 runs failed over last 7 days	14.18% (38) 38 / 268 runs flaked over last 7 days
authorized user sees correct translations (ar) should return correct translations and html attributes Retry 1 • Initial Attempt	-13.79% (-36) -36 / 261 runs failed over last 7 days	14.56% (38) 38 / 261 runs flaked over last 7 days
authorized user sees changed translations (de->ar) should return correct translations and html attributes Retry 1 • Initial Attempt	-12.74% (-33) -33 / 259 runs failed over last 7 days	14.67% (38) 38 / 259 runs flaked over last 7 days
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes Retry 1 • Initial Attempt	-9.84% (-25) -25 / 254 runs failed over last 7 days	14.17% (36) 36 / 254 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 2 • Retry 1 • Initial Attempt	7.02% (21) 21 / 299 runs failed over last 7 days	90.30% (270) 270 / 299 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	0% (0) 0 / 299 runs failed over last 7 days	52.17% (156) 156 / 299 runs flaked over last 7 days

📄 apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Teams Can create a private team Retry 1 • Initial Attempt	0% (0) 0 / 294 runs failed over last 7 days	5.10% (15) 15 / 294 runs flaked over last 7 days

📄 apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Reschedule for booking with seats If rescheduled/cancelled booking with seats it should display the correct number of seats Retry 2 • Retry 1 • Initial Attempt	4.45% (13) 13 / 292 runs failed over last 7 days	6.85% (20) 20 / 292 runs flaked over last 7 days

📄 apps/web/playwright/insights.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Insights should test download button Retry 1 • Initial Attempt	0% (0) 0 / 288 runs failed over last 7 days	3.47% (10) 10 / 288 runs flaked over last 7 days

View Detailed Build Results

…-location

hariombalhara

Fixed tests. Approving on behalf of already done approvals

Udit-takkar · 2023-10-24T12:30:51Z

@hariombalhara Thanks for fixing the tests ❤️

Co-authored-by: Peer Richelsen <peeroke@gmail.com>

zomars added the core area: core, team members only label Oct 10, 2023

vercel bot deployed to Preview – ai October 10, 2023 15:10 View deployment

vercel bot deployed to Preview – ui October 10, 2023 15:11 View deployment

vercel bot deployed to Preview – api October 10, 2023 15:13 View deployment

vercel bot deployed to Preview – cal-demo October 10, 2023 15:14 View deployment

vercel bot deployed to Preview – dev October 10, 2023 15:16 View deployment

feat: wip

a427a0d

Udit-takkar force-pushed the feat/add-location branch from 8a94efe to a427a0d Compare October 12, 2023 19:06

vercel bot deployed to Preview – ai October 12, 2023 19:09 View deployment

vercel bot had a problem deploying to Preview – api October 12, 2023 19:10 Failure

vercel bot deployed to Preview – ui October 12, 2023 19:10 View deployment

vercel bot deployed to Preview – dev October 12, 2023 19:13 View deployment

vercel bot deployed to Preview – cal-demo October 12, 2023 19:13 View deployment

Merge branch 'main' into feat/add-location

aa51415

vercel bot deployed to Preview – ai October 18, 2023 11:28 View deployment

vercel bot deployed to Preview – ui October 18, 2023 11:28 View deployment

vercel bot deployed to Preview – api October 18, 2023 11:30 View deployment

vercel bot deployed to Preview – dev October 18, 2023 11:32 View deployment

vercel bot deployed to Preview – cal-demo October 18, 2023 11:32 View deployment

Merge branch 'main' into feat/add-location

bf3aada

vercel bot deployed to Preview – ai October 18, 2023 12:51 View deployment

vercel bot deployed to Preview – api October 18, 2023 12:52 View deployment

vercel bot deployed to Preview – dev October 18, 2023 12:53 View deployment

vercel bot deployed to Preview – cal-demo October 18, 2023 12:53 View deployment

Udit-takkar added 2 commits October 18, 2023 20:49

feat: new location select

bee6159

chore: remove export

7ec9959

vercel bot deployed to Preview – cal-demo October 24, 2023 10:02 View deployment

Merge branch 'main' into feat/add-location

fe68d7e

vercel bot deployed to Preview – dev October 24, 2023 10:11 View deployment

vercel bot deployed to Preview – cal-demo October 24, 2023 10:14 View deployment

vercel bot deployed to Preview – api October 24, 2023 10:18 View deployment

vercel bot deployed to Preview – ai October 24, 2023 10:18 View deployment

Fix another test

58dff4d

hariombalhara dismissed PeerRich’s stale review via de2040f October 24, 2023 10:20

vercel bot deployed to Preview – dev October 24, 2023 10:27 View deployment

vercel bot deployed to Preview – cal-demo October 24, 2023 10:32 View deployment

vercel bot deployed to Preview – api October 24, 2023 10:35 View deployment

vercel bot deployed to Preview – ai October 24, 2023 10:36 View deployment

Merge remote-tracking branch 'origin/feat/add-location' into feat/add…

19d12d1

…-location

hariombalhara force-pushed the feat/add-location branch from de2040f to 19d12d1 Compare October 24, 2023 10:57

vercel bot deployed to Preview – api October 24, 2023 11:03 View deployment

vercel bot deployed to Preview – dev October 24, 2023 11:05 View deployment

vercel bot deployed to Preview – ai October 24, 2023 11:05 View deployment

vercel bot deployed to Preview – cal-demo October 24, 2023 11:10 View deployment

Merge branch 'main' into feat/add-location

158035c

vercel bot deployed to Preview – api October 24, 2023 12:17 View deployment

vercel bot deployed to Preview – ui October 24, 2023 12:18 View deployment

vercel bot deployed to Preview – dev October 24, 2023 12:18 View deployment

vercel bot deployed to Preview – ai October 24, 2023 12:21 View deployment

vercel bot deployed to Preview – cal-demo October 24, 2023 12:26 View deployment

hariombalhara approved these changes Oct 24, 2023

View reviewed changes

PeerRich merged commit 9250b91 into main Oct 24, 2023
37 checks passed

PeerRich deleted the feat/add-location branch October 24, 2023 12:29

hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023

feat: remove location modal in event setup (calcom#11796)

49e2789

Co-authored-by: Peer Richelsen <peeroke@gmail.com>

hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023

feat: remove location modal in event setup (calcom#11796)

0bae67e

Co-authored-by: Peer Richelsen <peeroke@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: remove location modal in event setup #11796

feat: remove location modal in event setup #11796

Udit-takkar commented Oct 10, 2023 •

edited

vercel bot commented Oct 10, 2023 •

edited

github-actions bot commented Oct 10, 2023 •

edited

github-actions bot commented Oct 10, 2023 •

edited

deploysentinel bot commented Oct 10, 2023 •

edited

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

hariombalhara left a comment

Udit-takkar commented Oct 24, 2023

feat: remove location modal in event setup #11796

feat: remove location modal in event setup #11796

Conversation

Udit-takkar commented Oct 10, 2023 • edited

What does this PR do?

Type of change

vercel bot commented Oct 10, 2023 • edited

github-actions bot commented Oct 10, 2023 • edited

github-actions bot commented Oct 10, 2023 • edited

📦 Next.js Bundle Analysis for @calcom/web

One Page Changed Size

deploysentinel bot commented Oct 10, 2023 • edited

Current Playwright Test Results Summary

⚠️ Flakes

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

hariombalhara left a comment

Choose a reason for hiding this comment

Udit-takkar commented Oct 24, 2023

Udit-takkar commented Oct 10, 2023 •

edited

vercel bot commented Oct 10, 2023 •

edited

github-actions bot commented Oct 10, 2023 •

edited

github-actions bot commented Oct 10, 2023 •

edited

deploysentinel bot commented Oct 10, 2023 •

edited