Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [app dir bootstrapping 2] ensure tests do not have explicit timeouts #11970

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

grzpab
Copy link
Contributor

@grzpab grzpab commented Oct 18, 2023

What does this PR do?

This PR ensures that selected tests do not fail due to a timeout.
These tests can fail when running the tests in parallel.
Instead of a timeout, we wait until certain conditions are met.

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

This PR changes the E2E tests.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 11:58pm
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 11:58pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 11:58pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 11:58pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2023 11:58pm

@vercel
Copy link

vercel bot commented Oct 18, 2023

@grzpab is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@PeerRich PeerRich added Low priority Created by Linear-GitHub Sync automated-tests area: unit tests, e2e tests, playwright labels Oct 20, 2023
@PeerRich PeerRich requested a review from a team October 20, 2023 14:48
@grzpab grzpab changed the title chore: ensure tests do not have explicit timeouts chore: [app dir bootstrapping 1] ensure tests do not have explicit timeouts Oct 20, 2023
@grzpab grzpab changed the title chore: [app dir bootstrapping 1] ensure tests do not have explicit timeouts chore: [app dir bootstrapping 2] ensure tests do not have explicit timeouts Oct 20, 2023
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@zomars zomars merged commit e91fe12 into calcom:main Oct 20, 2023
36 of 38 checks passed
@zomars zomars deleted the gpp/waitFor2 branch October 20, 2023 23:57
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests area: unit tests, e2e tests, playwright Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants