Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [app dir bootstrapping 5] add RootLayout #11982

Merged
merged 3 commits into from
Oct 25, 2023
Merged

chore: [app dir bootstrapping 5] add RootLayout #11982

merged 3 commits into from
Oct 25, 2023

Conversation

DmytroHryshyn
Copy link
Contributor

@DmytroHryshyn DmytroHryshyn commented Oct 18, 2023 •
edited

What does this PR do?

This PR adds bare minimum for app directory migration.

  • Adds RootLayout file
  • Adds a patch for libphonenumber-js library that solves module resolution issue
  • Adds app dir compatible versions of PageWrapper and app-providers

Requirement/Documentation

This PR contains patch of libphonenumber-js so yarn.lock should be regenerated.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

This PR adds a dead code that should not affect existing pages.
Known bug with libphonenumber lib is fixed with a patch.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link

vercel bot commented Oct 18, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 7:14pm

@vercel
Copy link

vercel bot commented Oct 18, 2023

@DmytroHryshyn is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023 •
edited

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023 •
edited

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Sixty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/404 83.37 KB 239.48 KB 68.42% (🟢 -1.76%)
/apps 262 KB 418.11 KB 119.46% (🟢 -1.70%)
/apps/[slug] 280.16 KB 436.27 KB 124.65% (🟢 -1.70%)
/apps/[slug]/[...pages] 536.18 KB 692.3 KB 197.80% (🟢 -0.22%)
/apps/categories 240.94 KB 397.05 KB 113.44% (🟢 -1.70%)
/apps/categories/[category] 244.98 KB 401.09 KB 114.60% (🟢 -1.70%)
/apps/installed/[category] 261.82 KB 417.93 KB 119.41% (🟢 -1.71%)
/availability 375.57 KB 531.68 KB 151.91% (🟢 -1.76%)
/availability/[schedule] 342.9 KB 499.01 KB 142.57% (🟢 -1.70%)
/availability/troubleshoot 241.65 KB 397.77 KB 113.65% (🟢 -1.70%)
/event-types 530.29 KB 686.41 KB 196.12% (🟢 -1.64%)
/event-types/[type] 383.48 KB 539.59 KB 154.17% (🟢 -9.18%)
/insights 460.99 KB 617.1 KB 176.31% (🟢 -1.70%)
/more 240.57 KB 396.68 KB 113.34% (🟢 -1.70%)
/settings/admin 247 KB 403.11 KB 115.17% (🟢 -1.70%)
/settings/admin/apps 259.65 KB 415.77 KB 118.79% (🟢 -1.71%)
/settings/admin/apps/[category] 259.64 KB 415.75 KB 118.79% (🟢 -1.71%)
/settings/admin/flags 250.54 KB 406.65 KB 116.19% (🟢 -1.71%)
/settings/admin/impersonation 247.27 KB 403.38 KB 115.25% (🟢 -1.70%)
/settings/admin/oAuth 247.98 KB 404.1 KB 115.46% (🟢 -1.71%)
/settings/admin/organizations 248.26 KB 404.38 KB 115.54% (🟢 -1.71%)
/settings/admin/users 249.03 KB 405.14 KB 115.75% (🟢 -1.70%)
/settings/admin/users/[id]/edit 337.61 KB 493.72 KB 141.06% (🟢 -1.70%)
/settings/admin/users/add 337.35 KB 493.46 KB 140.99% (🟢 -1.70%)
/settings/billing 247.19 KB 403.31 KB 115.23% (🟢 -1.70%)
/settings/developer/api-keys 251.42 KB 407.53 KB 116.44% (🟢 -1.70%)
/settings/developer/webhooks 251.32 KB 407.43 KB 116.41% (🟢 -1.70%)
/settings/developer/webhooks/[id] 252.13 KB 408.24 KB 116.64% (🟢 -1.70%)
/settings/developer/webhooks/new 252.13 KB 408.24 KB 116.64% (🟢 -1.70%)
/settings/my-account/appearance 269.25 KB 425.36 KB 121.53% (🟢 -1.70%)
/settings/my-account/calendars 253.76 KB 409.87 KB 117.11% (🟢 -1.70%)
/settings/my-account/conferencing 256.65 KB 412.76 KB 117.93% (🟢 -1.71%)
/settings/my-account/general 334.81 KB 490.92 KB 140.26% (🟢 -1.70%)
/settings/my-account/profile 372.03 KB 528.15 KB 150.90% (🟢 -1.77%)
/settings/organizations/[id]/about 137.76 KB 293.87 KB 83.96% (🟢 -1.75%)
/settings/organizations/[id]/add-teams 137.79 KB 293.91 KB 83.97% (🟢 -1.75%)
/settings/organizations/[id]/onboard-admins 137.81 KB 293.93 KB 83.98% (🟢 -1.75%)
/settings/organizations/[id]/set-password 137.76 KB 293.87 KB 83.96% (🟢 -1.75%)
/settings/organizations/appearance 259.36 KB 415.48 KB 118.71% (🟢 -1.70%)
/settings/organizations/billing 247.23 KB 403.34 KB 115.24% (🟢 -1.70%)
/settings/organizations/general 327.71 KB 483.82 KB 138.23% (🟢 -1.70%)
/settings/organizations/members 362.44 KB 518.55 KB 148.16% (🟢 -1.70%)
/settings/organizations/new 137.77 KB 293.88 KB 83.97% (🟢 -1.76%)
/settings/organizations/profile 369.17 KB 525.28 KB 150.08% (🟢 -1.70%)
/settings/organizations/teams/other 248.06 KB 404.17 KB 115.48% (🟢 -1.70%)
/settings/organizations/teams/other/[id]/appearance 256.26 KB 412.37 KB 117.82% (🟢 -1.70%)
/settings/organizations/teams/other/[id]/members 251.44 KB 407.56 KB 116.44% (🟢 -1.70%)
/settings/organizations/teams/other/[id]/profile 438.95 KB 595.06 KB 170.02% (🟢 -1.64%)
/settings/security/impersonation 252.05 KB 408.17 KB 116.62% (🟢 -1.70%)
/settings/security/password 260.81 KB 416.92 KB 119.12% (🟢 -1.70%)
/settings/security/sso 256.04 KB 412.15 KB 117.76% (🟢 -1.70%)
/settings/security/two-factor-auth 255.85 KB 411.97 KB 117.70% (🟢 -1.70%)
/settings/teams 246.75 KB 402.86 KB 115.10% (🟢 -1.69%)
/settings/teams/[id]/appearance 256.24 KB 412.35 KB 117.82% (🟢 -1.71%)
/settings/teams/[id]/billing 247.23 KB 403.35 KB 115.24% (🟢 -1.70%)
/settings/teams/[id]/members 369.08 KB 525.19 KB 150.05% (🟢 -1.75%)
/settings/teams/[id]/profile 439.33 KB 595.44 KB 170.13% (🟢 -1.64%)
/settings/teams/[id]/sso 256.53 KB 412.65 KB 117.90% (🟢 -1.70%)
/signup 124.28 KB 280.39 KB 80.11% (🟢 -1.75%)
/teams 240.83 KB 396.95 KB 113.41% (🟢 -1.70%)
/workflows 278.26 KB 434.37 KB 124.11% (🟢 -1.71%)
/workflows/[workflow] 388.74 KB 544.85 KB 155.67% (🟢 -1.70%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@DmytroHryshyn DmytroHryshyn marked this pull request as draft October 19, 2023 09:22
@DmytroHryshyn DmytroHryshyn mentioned this pull request Oct 20, 2023
Closed
4 tasks
@DmytroHryshyn DmytroHryshyn marked this pull request as ready for review October 20, 2023 16:02
@DmytroHryshyn DmytroHryshyn changed the title chore: add RootLayout chore: [app dir bootstrapping 5] add RootLayout Oct 20, 2023
@socket-security
Copy link

socket-security bot commented Oct 20, 2023 •
edited

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@PeerRich PeerRich added the Medium priority Created by Linear-GitHub Sync label Oct 20, 2023
@github-actions github-actions bot added the 🚨 merge conflict This PR has a merge conflict that has to be addressed label Oct 20, 2023
@DmytroHryshyn DmytroHryshyn force-pushed the dmytro/new-layout-chunk branch 2 times, most recently from 20affae to 23b66db Compare October 23, 2023 10:27
@github-actions github-actions bot removed the 🚨 merge conflict This PR has a merge conflict that has to be addressed label Oct 23, 2023
@zomars zomars self-requested a review October 23, 2023 19:06
@zomars zomars self-assigned this Oct 23, 2023
zomars
zomars approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good to merge

@zomars zomars merged commit 139a7c8 into calcom:main Oct 25, 2023
27 of 34 checks passed
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023
@DmytroHryshyn @zomars
@grzpab @hbjORbj
chore: [app dir bootstrapping 5] add RootLayout (calcom#11982)
b8a8c7c 
Co-authored-by: zomars <zomars@me.com>
Co-authored-by: Greg Pabian <35925521+grzpab@users.noreply.github.com>
@jkcs jkcs mentioned this pull request Nov 30, 2023
Merged
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
@DmytroHryshyn @zomars
@grzpab @hbjORbj
chore: [app dir bootstrapping 5] add RootLayout (calcom#11982)
b854a59 
Co-authored-by: zomars <zomars@me.com>
Co-authored-by: Greg Pabian <35925521+grzpab@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzpab grzpab grzpab left review comments

@zomars zomars zomars approved these changes

Assignees

@zomars zomars

Labels
Medium priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DmytroHryshyn @zomars @grzpab @PeerRich