Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: smooth transitions to interactive elements #11983

Merged
merged 6 commits into from Nov 12, 2023

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Oct 18, 2023

What does this PR do?

Most interactive elements have hover and focus effects but the transition is instant so it feels a bit jarring. This PR makes all transitions as smooth as possible.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Interact with elements that have hover and focus effects and you'll notice that they all transition smoothly

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 2:51pm

@vercel
Copy link

vercel bot commented Oct 18, 2023

@hichemfantar is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@hichemfantar hichemfantar changed the title apply smooth transitions to buttons and inputs feat: smooth transitions to interactive elements Oct 18, 2023
@PeerRich
Copy link
Member

can you record a loom.com video?

@PeerRich PeerRich added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input labels Oct 20, 2023
@hichemfantar
Copy link
Contributor Author

@hichemfantar
Copy link
Contributor Author

@PeerRich can we merge this soon since all checks seem to be passing.

@PeerRich PeerRich enabled auto-merge (squash) November 12, 2023 17:22
@PeerRich PeerRich merged commit 4db0da5 into calcom:main Nov 12, 2023
27 of 36 checks passed
@hichemfantar hichemfantar deleted the smooth-transitions branch November 14, 2023 10:16
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
zomars pushed a commit that referenced this pull request Jan 29, 2024
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants