fix: booking day wrong in booking list #12007
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 182 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/20/2023 06:42:47am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 39c020c Started: 10/20/2023 06:40:13am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 2 • Retry 1 • Initial Attempt |
0.73% (2)2 / 275 runsfailed over last 7 days |
10.18% (28)28 / 275 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration When event is paid and confirmed Payment should confirm pending payment booking
Retry 1 • Initial Attempt |
1.80% (5)5 / 278 runsfailed over last 7 days |
1.80% (5)5 / 278 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
7.37% (21)21 / 285 runsfailed over last 7 days |
90.53% (258)258 / 285 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
2.10% (6)6 / 286 runsfailed over last 7 days |
48.60% (139)139 / 286 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link should validate fields
Retry 1 • Initial Attempt |
0.35% (1)1 / 283 runfailed over last 7 days |
13.07% (37)37 / 283 runsflaked over last 7 days |
CarinaWolli
added
🐛 bug
Udit-takkar
reviewed
Oct 20, 2023
There was a problem hiding this comment.
@CarinaWolli nice catch.
we would also have add .tz(userTimezone) at few places in bookings/[status].tsx also
cal.com/apps/web/pages/bookings/[status].tsx
Line 135 in 19eced0
As you can see in the screenshot the second 20th october meeting doesn't show up in bookingsToday
PeerRich
approved these changes
Oct 24, 2023
|
follow up #12053 |
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Nov 28, 2023
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the following scenario:
User Timezone: New York
If there is a booking at 11:00 PM on 9th of November, it was shown on Nov 10th in the list of upcoming bookings:
It's showed the day of the UTC time.