Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: env.example requesting 24 bytes instead of 32 bytes encryption key #12043

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix: env.example requesting 24 bytes instead of 32 bytes encryption key #12043

merged 1 commit into from
Oct 24, 2023

Conversation

mattinannt
Copy link
Contributor

What does this PR do?

The current .env.example file is mentioning:

# Application Key for symmetric encryption and decryption
# must be 32 bytes for AES256 encryption algorithm
# You can use: `openssl rand -base64 24` to generate one

But the command openssl rand -base64 24 is generating a 24 bytes key (32 characters) instead of a 32 bytes string. To follow the instructions the command should be: openssl rand -base64 32

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link

vercel bot commented Oct 23, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 3:08pm

@vercel
Copy link

vercel bot commented Oct 23, 2023

@mattinannt is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Oct 23, 2023
@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 153.94 KB (🟢 -2.15 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Hundred Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/404 95.49 KB 249.42 KB 71.26% (🟡 +3.47%)
/500 90.14 KB 244.08 KB 69.74% (🟡 +1.64%)
/[user] 102.47 KB 256.41 KB 73.26% (🟡 +4.14%)
/[user]/[type] 402.28 KB 556.22 KB 158.92% (🔴 +47.57%)
/[user]/[type]/embed 402.31 KB 556.25 KB 158.93% (🔴 +47.57%)
/[user]/embed 102.5 KB 256.44 KB 73.27% (🟡 +4.14%)
/_error 45.63 KB 199.57 KB 57.02% (🟡 +5.40%)
/apps 290.04 KB 443.98 KB 126.85% (🟡 +8.01%)
/apps/[slug] 308.55 KB 462.49 KB 132.14% (🟡 +8.11%)
/apps/[slug]/[...pages] 617.56 KB 771.5 KB 220.43% (🔴 +23.25%)
/apps/[slug]/setup 92.86 KB 246.8 KB 70.51% (🟡 +3.51%)
/apps/categories 251.86 KB 405.79 KB 115.94% (🟡 +3.12%)
/apps/categories/[category] 273.42 KB 427.36 KB 122.10% (🟡 +8.13%)
/apps/installed/[category] 272.33 KB 426.27 KB 121.79% (🟡 +3.00%)
/auth/error 105.19 KB 259.13 KB 74.04% (🟡 +3.31%)
/auth/forgot-password 139.8 KB 293.74 KB 83.93% (🟡 +12.51%)
/auth/forgot-password/[id] 139.18 KB 293.12 KB 83.75% (🟡 +11.29%)
/auth/login 155.48 KB 309.42 KB 88.41% (🟡 +12.23%)
/auth/logout 93.98 KB 247.92 KB 70.84% (🟡 +3.60%)
/auth/saml-idp 84.52 KB 238.46 KB 68.13% (🟡 +1.63%)
/auth/setup 175.62 KB 329.56 KB 94.16% (🟡 +9.39%)
/auth/signin 84.6 KB 238.54 KB 68.15% (🟡 +1.63%)
/auth/sso/[provider] 84.63 KB 238.57 KB 68.16% (🟡 +1.63%)
/auth/sso/direct 84.56 KB 238.5 KB 68.14% (🟡 +1.63%)
/auth/verify 102.36 KB 256.3 KB 73.23% (🟡 +1.30%)
/auth/verify-email 89.98 KB 243.92 KB 69.69% (🟡 +1.62%)
/availability 257.39 KB 411.33 KB 117.52% (🟢 -33.76%)
/availability/[schedule] 353.85 KB 507.79 KB 145.08% (🟡 +3.13%)
/availability/troubleshoot 252.53 KB 406.47 KB 116.13% (🟡 +3.11%)
/booking/[uid] 325.99 KB 479.93 KB 137.12% (🔴 +41.42%)
/bookings/[status] 343.97 KB 497.91 KB 142.26% (🟡 +8.77%)
/d/[link]/[slug] 402.29 KB 556.23 KB 158.92% (🔴 +47.58%)
/event-types 597.42 KB 751.36 KB 214.67% (🟡 +19.17%)
/event-types/[type] 481.34 KB 635.28 KB 181.51% (🔴 +27.96%)
/getting-started/[[...step]] 404.1 KB 558.04 KB 159.44% (🟡 +4.18%)
/insights 472.04 KB 625.98 KB 178.85% (🟡 +3.16%)
/maintenance 84.74 KB 238.68 KB 68.19% (🟡 +1.63%)
/more 251.48 KB 405.42 KB 115.84% (🟡 +3.12%)
/org/[orgSlug] 231.87 KB 385.81 KB 110.23% (🟡 +3.55%)
/org/[orgSlug]/[user] 238.04 KB 391.98 KB 111.99% (🟡 +3.49%)
/org/[orgSlug]/[user]/[type] 402.44 KB 556.38 KB 158.97% (🔴 +47.56%)
/org/[orgSlug]/[user]/[type]/embed 402.47 KB 556.41 KB 158.97% (🔴 +47.57%)
/org/[orgSlug]/team/[slug] 231.88 KB 385.82 KB 110.23% (🟡 +3.55%)
/org/[orgSlug]/team/[slug]/[type] 402.33 KB 556.27 KB 158.93% (🔴 +47.58%)
/payment/[uid] 124.46 KB 278.4 KB 79.54% (🟡 +4.13%)
/settings/admin 257.76 KB 411.7 KB 117.63% (🟡 +3.07%)
/settings/admin/apps 270.24 KB 424.18 KB 121.19% (🟡 +3.03%)
/settings/admin/apps/[category] 270.22 KB 424.16 KB 121.19% (🟡 +3.02%)
/settings/admin/flags 261.31 KB 415.25 KB 118.64% (🟡 +3.08%)
/settings/admin/impersonation 258.03 KB 411.97 KB 117.71% (🟡 +3.07%)
/settings/admin/organizations 258.81 KB 412.75 KB 117.93% (🟡 +3.01%)
/settings/admin/users 259.8 KB 413.74 KB 118.21% (🟡 +3.08%)
/settings/admin/users/[id]/edit 349.53 KB 503.47 KB 143.85% (🟡 +3.40%)
/settings/admin/users/add 349.24 KB 503.18 KB 143.77% (🟡 +3.39%)
/settings/billing 257.9 KB 411.84 KB 117.67% (🟡 +3.06%)
/settings/developer/api-keys 262.43 KB 416.37 KB 118.96% (🟡 +3.15%)
/settings/developer/webhooks 262.01 KB 415.95 KB 118.84% (🟡 +3.06%)
/settings/developer/webhooks/[id] 263.24 KB 417.18 KB 119.19% (🟡 +3.18%)
/settings/developer/webhooks/new 263.2 KB 417.14 KB 119.18% (🟡 +3.17%)
/settings/my-account/appearance 277.72 KB 431.66 KB 123.33% (🟡 +2.43%)
/settings/my-account/calendars 264.29 KB 418.23 KB 119.49% (🟡 +3.02%)
/settings/my-account/conferencing 263.9 KB 417.83 KB 119.38% (🟡 +2.07%)
/settings/my-account/general 345.64 KB 499.58 KB 142.74% (🟡 +3.09%)
/settings/my-account/profile 384.62 KB 538.56 KB 153.87% (🟡 +3.60%)
/settings/organizations/[id]/about 171.75 KB 325.69 KB 93.06% (🟡 +9.71%)
/settings/organizations/[id]/add-teams 171.79 KB 325.73 KB 93.07% (🟡 +9.71%)
/settings/organizations/[id]/onboard-admins 171.81 KB 325.75 KB 93.07% (🟡 +9.71%)
/settings/organizations/[id]/set-password 171.75 KB 325.69 KB 93.06% (🟡 +9.71%)
/settings/organizations/appearance 264.61 KB 418.55 KB 119.59% (🟡 +1.50%)
/settings/organizations/billing 257.74 KB 411.68 KB 117.62% (🟡 +3.01%)
/settings/organizations/general 338.37 KB 492.31 KB 140.66% (🟡 +3.05%)
/settings/organizations/members 287.51 KB 441.45 KB 126.13% (🟢 -21.41%)
/settings/organizations/new 171.76 KB 325.7 KB 93.06% (🟡 +9.71%)
/settings/organizations/profile 379.2 KB 533.14 KB 152.33% (🟡 +2.86%)
/settings/organizations/teams/other 258.91 KB 412.85 KB 117.96% (🟡 +3.10%)
/settings/organizations/teams/other/[id]/appearance 267.23 KB 421.17 KB 120.33% (🟡 +3.14%)
/settings/organizations/teams/other/[id]/members 261.88 KB 415.82 KB 118.80% (🟡 +2.99%)
/settings/organizations/teams/other/[id]/profile 448.38 KB 602.32 KB 172.09% (🟡 +2.70%)
/settings/security/impersonation 260.4 KB 414.34 KB 118.38% (🟡 +2.39%)
/settings/security/password 272.14 KB 426.08 KB 121.74% (🟡 +3.24%)
/settings/security/sso 267.18 KB 421.12 KB 120.32% (🟡 +3.19%)
/settings/security/two-factor-auth 263.02 KB 416.96 KB 119.13% (🟡 +2.05%)
/settings/teams 257.5 KB 411.44 KB 117.56% (🟡 +3.07%)
/settings/teams/[id]/appearance 267.22 KB 421.16 KB 120.33% (🟡 +3.14%)
/settings/teams/[id]/billing 257.74 KB 411.68 KB 117.62% (🟡 +3.01%)
/settings/teams/[id]/members 379.71 KB 533.65 KB 152.47% (🟡 +3.04%)
/settings/teams/[id]/onboard-members 168.83 KB 322.76 KB 92.22% (🟡 +5.64%)
/settings/teams/[id]/profile 449.13 KB 603.07 KB 172.31% (🟡 +2.80%)
/settings/teams/[id]/sso 267.29 KB 421.23 KB 120.35% (🟡 +3.07%)
/settings/teams/new 192.29 KB 346.23 KB 98.92% (🟡 +1.97%)
/signup 151.45 KB 305.39 KB 87.25% (🟡 +7.77%)
/team/[slug] 231.83 KB 385.77 KB 110.22% (🟡 +3.55%)
/team/[slug]/[type] 402.29 KB 556.23 KB 158.92% (🔴 +47.58%)
/team/[slug]/[type]/embed 402.32 KB 556.26 KB 158.93% (🔴 +47.58%)
/team/[slug]/embed 231.88 KB 385.82 KB 110.23% (🟡 +3.55%)
/teams 251.63 KB 405.57 KB 115.88% (🟡 +3.08%)
/video/[uid] 240.93 KB 394.87 KB 112.82% (🟡 +1.06%)
/video/meeting-ended/[uid] 100.64 KB 254.58 KB 72.74% (🟡 +3.54%)
/video/meeting-not-started/[uid] 100.28 KB 254.22 KB 72.63% (🟡 +3.55%)
/video/no-meeting-found 92.55 KB 246.49 KB 70.43% (🟡 +3.54%)
/workflows 286.75 KB 440.69 KB 125.91% (🟡 +2.43%)
/workflows/[workflow] 398.91 KB 552.85 KB 157.96% (🟡 +2.90%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@PeerRich PeerRich merged commit 19f5242 into calcom:main Oct 24, 2023
29 of 33 checks passed
@mattinannt
Copy link
Contributor Author

@PeerRich Can someone with knowledge of how cal.com uses the encryption key check on this? I'm not sure anymore as it also seems to depend on how the key is processed and used in different encryption algorithms.

@nicktrn
Copy link
Contributor

nicktrn commented Oct 31, 2023

also seems to depend on how the key is processed and used in different encryption algorithms

Quite right. Anyone following the new advice of generating 32 byte keys will actually break the encryption feature.

This would have to be done in conjunction with the proposed changes in #10805.

hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023
@mattinannt @hbjORbj
fix: env.example requesting 24 bytes instead of 32 bytes encryption k…
15823e3 
…ey (calcom#12043)
@stabildev stabildev mentioned this pull request Dec 7, 2023
Merged
1 task
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
@mattinannt @hbjORbj
fix: env.example requesting 24 bytes instead of 32 bytes encryption k…
f157893 
…ey (calcom#12043)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

Assignees
No one assigned
Labels
❗️ .env changes contains changes to env variables
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattinannt @nicktrn @PeerRich