Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Event Type header layout issues (fix-headerLayout) #12047

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Oct 23, 2023

DEMO

Before:

image

After:

image

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 7:51am
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 7:51am
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 7:51am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 7:51am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 7:51am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 7:51am
qa ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 7:51am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

deploysentinel bot commented Oct 23, 2023

Current Playwright Test Results Summary

✅ 184 Passing - ⚠️ 10 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/24/2023 07:49:34am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 10b4a07

Started: 10/24/2023 07:45:54am UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
0.36% (1) 1 / 276 run
failed over last 7 days
31.16% (86) 86 / 276 runs
flaked over last 7 days

📄   apps/web/playwright/change-username.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Change username on settings User can change username to include periods(or dots)
Retry 1Initial Attempt
0% (0) 0 / 28 runs
failed over last 7 days
35.71% (10) 10 / 28 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Stripe integration dashboard Can add Stripe integration
Retry 1Initial Attempt
0.35% (1) 1 / 282 run
failed over last 7 days
0.71% (2) 2 / 282 runs
flaked over last 7 days
Stripe integration Can book a paid booking
Retry 2Retry 1Initial Attempt
0.36% (1) 1 / 280 run
failed over last 7 days
7.14% (20) 20 / 280 runs
flaked over last 7 days
Stripe integration Paid booking should be able to be rescheduled
Retry 2Retry 1Initial Attempt
0.72% (2) 2 / 279 runs
failed over last 7 days
6.81% (19) 19 / 279 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load
Retry 1Initial Attempt
0% (0) 0 / 282 runs
failed over last 7 days
4.61% (13) 13 / 282 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
6.67% (19) 19 / 285 runs
failed over last 7 days
90.53% (258) 258 / 285 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
0% (0) 0 / 286 runs
failed over last 7 days
52.10% (149) 149 / 286 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams Profile page is loaded for users in Organization
Retry 1Initial Attempt
0% (0) 0 / 277 runs
failed over last 7 days
32.49% (90) 90 / 277 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0% (0) 0 / 282 runs
failed over last 7 days
12.41% (35) 35 / 282 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sean-brydon sean-brydon merged commit 4ed15d2 into main Oct 24, 2023
37 checks passed
@sean-brydon sean-brydon deleted the fix-headerLayout branch October 24, 2023 08:49
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023
Co-authored-by: gitstart-calcom <gitstart-calcom@users.noreply.github.com>
Co-authored-by: GitStart-Cal.com <121884634+gitstart-calcom@users.noreply.github.com>
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Co-authored-by: gitstart-calcom <gitstart-calcom@users.noreply.github.com>
Co-authored-by: GitStart-Cal.com <121884634+gitstart-calcom@users.noreply.github.com>
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants