Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Teams listing and wrong avatars - Cross org boundary scenario #12070

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Oct 25, 2023

What does this PR do?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Scenario-1

  • Create two users with same username(one in org and one outside). Notice that the avatar for the org user uses non-org user's avatar on Team Assignment page, event-types list. This bug is now fixed.

Scenario-2

  • As an org user, make yourself part of a non-org team by directly creating a membership with that team
  • Test that you can see the team in /teams when logged in as org member.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ❌ Failed (Inspect) Oct 25, 2023 2:57am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 2:57am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 2:57am
cal ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 2:57am
cal-demo ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 2:57am
qa ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 2:57am
ui ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 2:57am

@zomars zomars added the core area: core, team members only label Oct 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@hariombalhara hariombalhara changed the title Fixes in teams and avatar across org fix: Teams listing and wrong avatars - Cross org boundary scenario Oct 25, 2023
@hariombalhara hariombalhara marked this pull request as ready for review October 25, 2023 02:45
@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

deploysentinel bot commented Oct 25, 2023

Current Playwright Test Results Summary

✅ 48 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/25/2023 08:43:52am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 3e0fa1a

Started: 10/25/2023 08:42:24am UTC

⚠️ Flakes

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule for booking with seats If rescheduled/cancelled booking with seats it should display the correct number of seats
Retry 1Initial Attempt
7.02% (20) 20 / 285 runs
failed over last 7 days
9.47% (27) 27 / 285 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@ThyMinimalDev ThyMinimalDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hariombalhara hariombalhara merged commit af801df into main Oct 25, 2023
37 of 40 checks passed
@hariombalhara hariombalhara deleted the cross-org-fixes branch October 25, 2023 10:27
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants