Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the padding and position of tabs on the Team Availability page and Organisation Members page #12078

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

Siddharth-2382
Copy link
Contributor

What does this PR do?

The team availability page had a lot of padding which couldn't be fixed without breaking the organisation members page as both use the same DataTable component.

I added Search on the Team Availability page and also made some minor adjustment to CSS of sticky header for the DataTable.

Fixes #12025

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  1. Create a team, add a lot of members to it.
  2. Go to Availability>Team Availability.
  3. See the visual differences.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link

vercel bot commented Oct 25, 2023

@Siddharth-2382 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync 🐛 bug Something isn't working 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Oct 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@Siddharth-2382
Copy link
Contributor Author

Organisation Members page currently:

Screen.Recording.2023-10-25.at.2.29.07.PM.mov

After changes:

Team Availability page:

Screen.Recording.2023-10-25.at.2.29.48.PM.mov

Organisation Members page:

Screen.Recording.2023-10-25.at.2.29.27.PM.mov

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes - thanks for this <3

@sean-brydon sean-brydon enabled auto-merge (squash) October 26, 2023 08:17
@sean-brydon sean-brydon merged commit defa8df into calcom:main Oct 26, 2023
27 of 35 checks passed
@Siddharth-2382 Siddharth-2382 deleted the cal/teams_ta branch October 26, 2023 08:31
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023
…age (calcom#12078)

Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
…age (calcom#12078)

Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the padding and position of tabs on the Team Availability page
2 participants