fix: cal video recording email #12079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 231 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/31/2023 04:29:51pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: d4b95f0 Started: 10/31/2023 04:24:46pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 2 • Retry 1 • Initial Attempt |
2.73% (9)9 / 330 runsfailed over last 7 days |
48.79% (161)161 / 330 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
16.97% (56)56 / 330 runsfailed over last 7 days |
80.91% (267)267 / 330 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Login and logout tests Login flow validations Should warn when password is incorrect
Retry 1 • Initial Attempt |
0% (0)0 / 313 runsfailed over last 7 days |
0.32% (1)1 / 313 runflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg Can create a booking for Collective EventType
Retry 1 • Initial Attempt |
0% (0)0 / 129 runsfailed over last 7 days |
0.78% (1)1 / 129 runflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/embed-pages.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Embed Pages isEmbed, getEmbedNamespace, getEmbedTheme testing when `window.name` is set to 'cal-embed=' and `theme` is supplied as a query param
Retry 1 • Initial Attempt |
0% (0)0 / 321 runsfailed over last 7 days |
0.62% (2)2 / 321 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1 • Initial Attempt |
0% (0)0 / 321 runsfailed over last 7 days |
7.48% (24)24 / 321 runsflaked over last 7 days |
emrysal
previously requested changes
Oct 25, 2023
6 tasks
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Nov 28, 2023
* fix: cal video recording email * fix: add check for recording * chore: remove logs * chore: change message --------- Co-authored-by: Peer Richelsen <peeroke@gmail.com>
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
* fix: cal video recording email * fix: add check for recording * chore: remove logs * chore: change message --------- Co-authored-by: Peer Richelsen <peeroke@gmail.com>
zomars
pushed a commit
that referenced
this pull request
Jan 29, 2024
* fix: cal video recording email * fix: add check for recording * chore: remove logs * chore: change message --------- Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12076
Added another button "Check for Recordings" just in case isRecorded field in DB is not updated to true due to error or failure. User would still be check if there are any recordings
Email:-
Screen.Recording.2023-10-25.at.10.43.27.PM.mov
Screen.Recording.2023-10-25.at.10.38.08.PM.mov