fix: embed rewrites post dotted usernames #12087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 13 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/25/2023 07:32:29pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: fa1f18b Started: 10/25/2023 07:31:41pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
8.21% (27)27 / 329 runsfailed over last 7 days |
89.36% (294)294 / 329 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
0.61% (2)2 / 329 runsfailed over last 7 days |
50.15% (165)165 / 329 runsflaked over last 7 days |
zomars
requested review from
emrysal,
hariombalhara,
Udit-takkar,
keithwillcode and
ThyMinimalDev
keithwillcode
approved these changes
Oct 25, 2023
keithwillcode
deleted the
10-25-fix_embed_rewrites_post_dotted_usernames
branch
zomars
added a commit
that referenced
this pull request
Oct 25, 2023
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Nov 28, 2023
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes embeds 404 error introduced in #11706
Type of change
How should this be tested?
<PREVIEW_URL>/embed.js should not return a 404
https://dev-p1jlmmiks-cal-staging.vercel.app/embed.js
Mandatory Tasks
Checklist