Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: E2E for Orgs - The beginning #12095

Merged
merged 4 commits into from
Oct 27, 2023
Merged

test: E2E for Orgs - The beginning #12095

merged 4 commits into from
Oct 27, 2023

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Oct 26, 2023

What does this PR do?

  • Added orgs fixture
  • Added a team creation test in Org
  • Added a team event booking test for Org Team

Type of change

  • Tests
  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

yarn e2e

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 0:04am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 0:04am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api ⬜️ Ignored (Inspect) Visit Preview Oct 27, 2023 0:04am
cal ⬜️ Ignored (Inspect) Visit Preview Oct 27, 2023 0:04am
cal-demo ⬜️ Ignored (Inspect) Visit Preview Oct 27, 2023 0:04am
qa ⬜️ Ignored (Inspect) Visit Preview Oct 27, 2023 0:04am
ui ⬜️ Ignored (Inspect) Visit Preview Oct 27, 2023 0:04am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@zomars zomars added the core area: core, team members only label Oct 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

deploysentinel bot commented Oct 26, 2023

Current Playwright Test Results Summary

✅ 231 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/27/2023 12:08:58pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: b8499ab

Started: 10/27/2023 12:05:01pm UTC

⚠️ Flakes

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration When event is paid and confirmed Paid and confirmed booking should be able to be rescheduled
Retry 1Initial Attempt
0% (0) 0 / 278 runs
failed over last 7 days
3.60% (10) 10 / 278 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
9.59% (28) 28 / 292 runs
failed over last 7 days
88.36% (258) 258 / 292 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
1.71% (5) 5 / 292 runs
failed over last 7 days
52.40% (153) 153 / 292 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg Can create a private team
Retry 1Initial Attempt
0% (0) 0 / 5 runs
failed over last 7 days
80% (4) 4 / 5 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1Initial Attempt
1.06% (3) 3 / 282 runs
failed over last 7 days
14.54% (41) 41 / 282 runs
flaked over last 7 days

View Detailed Build Results


@leog
Copy link
Contributor

leog commented Oct 26, 2023

@hariombalhara just in case it helps as complementary tests #11804

@hariombalhara
Copy link
Member Author

@leog Thankyou 🙏 Will merge soon.
Wasn't aware of the PR.

@leog
Copy link
Contributor

leog commented Oct 26, 2023

@leog Thankyou 🙏 Will merge soon. Wasn't aware of the PR.

my pleasure @hariombalhara, also, check this one for org seed in a simplified way: #10147

Comment on lines +40 to +48
if (!currentHostname) {
log.warn("Match of WEBAPP_URL with ALLOWED_HOSTNAME failed", { WEBAPP_URL, ALLOWED_HOSTNAMES });
return null;
}
// Define which is the current domain/subdomain
const slug = hostname.replace(`.${currentHostname}` ?? "", "");
const hasNoDotInSlug = slug.indexOf(".") === -1;
if (hasNoDotInSlug) {
return slug;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added better logs and made the code more readable

Udit-takkar
Udit-takkar previously approved these changes Oct 27, 2023
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hariombalhara
Copy link
Member Author

hariombalhara commented Oct 27, 2023

@PeerRich PeerRich merged commit 426d317 into main Oct 27, 2023
37 of 51 checks passed
@PeerRich PeerRich deleted the e2e/org-booking branch October 27, 2023 12:44
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
zomars pushed a commit that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests area: unit tests, e2e tests, playwright automerge core area: core, team members only Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants