Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pull managed event type bookings in zapier #12106

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

CarinaWolli
Copy link
Member

What does this PR do?

Managed event type bookings weren't pulled when testing zapier trigger (listBookings endpoint). This worked with API keys but not with OAuth

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ❌ Failed (Inspect) Oct 26, 2023 2:05pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 2:05pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:05pm
cal ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:05pm
cal-demo ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:05pm
ui ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:05pm

@github-actions
Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@zomars zomars added the core area: core, team members only label Oct 26, 2023
Copy link
Member

@alishaz-polymath alishaz-polymath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@deploysentinel
Copy link

deploysentinel bot commented Oct 26, 2023

Current Playwright Test Results Summary

✅ 228 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/26/2023 02:07:44pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 3a1b4cd

Started: 10/26/2023 02:03:36pm UTC

⚠️ Flakes

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1Initial Attempt
0.66% (2) 2 / 305 runs
failed over last 7 days
12.79% (39) 39 / 305 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
10.13% (32) 32 / 316 runs
failed over last 7 days
87.34% (276) 276 / 316 runs
flaked over last 7 days
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
1.58% (5) 5 / 317 runs
failed over last 7 days
46.37% (147) 147 / 317 runs
flaked over last 7 days

View Detailed Build Results


@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@CarinaWolli CarinaWolli merged commit 52386e0 into main Oct 26, 2023
37 of 38 checks passed
@CarinaWolli CarinaWolli deleted the fix/list-bookings-managed-event-type branch October 26, 2023 14:18
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants