Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding managed event type to workflow #12111

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

CarinaWolli
Copy link
Member

What does this PR do?

Fixes that managed event type couldn't be added to a user workflow. It didn't throw any error, but the managed event type just got ignored.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Create managed event type and assign yourself
  • Create a new user workflow
  • Add managed event type in the dropdown
  • Click save
  • Go back to workflow and check if managed event type is checked in dropdown

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 9:38pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 9:38pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api ⬜️ Ignored (Inspect) Oct 26, 2023 9:38pm
cal ⬜️ Ignored (Inspect) Oct 26, 2023 9:38pm
cal-demo ⬜️ Ignored (Inspect) Oct 26, 2023 9:38pm
ui ⬜️ Ignored (Inspect) Oct 26, 2023 9:38pm

@github-actions
Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@zomars zomars added the core area: core, team members only label Oct 26, 2023
id: {
in: activeOn,
},
parentId: null,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we excluded all managed event type children, we only want to do that for team workflows

@CarinaWolli CarinaWolli added the Medium priority Created by Linear-GitHub Sync label Oct 26, 2023
@CarinaWolli CarinaWolli requested review from a team and removed request for a team October 26, 2023 21:32
@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

deploysentinel bot commented Oct 26, 2023

Current Playwright Test Results Summary

✅ 17 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/27/2023 12:43:54am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: ebdea3c

Started: 10/27/2023 12:43:17am UTC

⚠️ Flakes

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1Initial Attempt
4.81% (13) 13 / 270 runs
failed over last 7 days
3.70% (10) 10 / 270 runs
flaked over last 7 days

View Detailed Build Results


@supalarry
Copy link
Contributor

supalarry commented Oct 27, 2023

I wanted to test this locally but don't see Click save button after adding managed event type to workflow. Is there some setting I need to enable?

Screenshot 2023-10-27 at 11 22 55

Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Udit-takkar
Copy link
Contributor

I wanted to test this locally but don't see Click save button after adding managed event type to workflow. Is there some setting I need to enable?

@supalarry looks like you need a dev license key in .env file.

@Udit-takkar Udit-takkar merged commit 09ecd44 into main Oct 27, 2023
39 checks passed
@Udit-takkar Udit-takkar deleted the fix/managed-event-type-workflows branch October 27, 2023 12:00
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
zomars pushed a commit that referenced this pull request Jan 29, 2024
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants