fix: impersonation for orgs #12113
Merged
fix: impersonation for orgs #12113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
sean-brydon
commented
Oct 27, 2023
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 231 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/30/2023 12:37:27pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 2f23471 Started: 10/30/2023 12:33:20pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Embed Code Generator Tests Event Types Page open Embed Dialog and choose element-click for First Event Type
Retry 1 • Initial Attempt |
0% (0)0 / 277 runsfailed over last 7 days |
0.72% (2)2 / 277 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Short text question Long Text and Short text required
Retry 1 • Initial Attempt |
0% (0)0 / 186 runsfailed over last 7 days |
1.61% (3)3 / 186 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
0.71% (2)2 / 281 runsfailed over last 7 days |
27.76% (78)78 / 281 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
14.09% (42)42 / 298 runsfailed over last 7 days |
83.89% (250)250 / 298 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
3.03% (9)9 / 297 runsfailed over last 7 days |
54.55% (162)162 / 297 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg Can create a private team
Retry 1 • Initial Attempt |
0% (0)0 / 61 runsfailed over last 7 days |
18.03% (11)11 / 61 runsflaked over last 7 days |
Udit-takkar
reviewed
Oct 27, 2023
its located in the org members table -> three ∂ots and impersonate |
packages/features/ee/impersonation/lib/ImpersonationProvider.ts
Outdated
Show resolved
Hide resolved
packages/features/ee/impersonation/lib/ImpersonationProvider.ts
Outdated
Show resolved
Hide resolved
ThyMinimalDev
approved these changes
Oct 30, 2023
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Nov 28, 2023
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
zomars
pushed a commit
that referenced
this pull request
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes impersonation in an org context:
How to test:
Org admins/owners can impersonate anyone in the org if they have impersonation enabeld
Org Team owners/admins can impersonate anyone in THAT org team if they have impersonation enabled
Normal team/admin impersonation should remain the same