Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [CAL-2654] Broken Icons in org invitation email #12119

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

nyctonio
Copy link
Contributor

What does this PR do?

In this PR, I've addressed the issue with the SVG icons in the organization invitation email. Previously, the icon height was inconsistently increased. By setting both a minimum height and maximum height, I've ensured the icons maintain their desired size and won't shrink.

Fixes [CAL-2654] Broken Icons in org invitation email #12112

Requirement/Documentation

No documentation is needed

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

This is a similar working example of the solution https://codesandbox.io/s/adoring-shtern-ttpdzd?file=/src/App.js

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link

vercel bot commented Oct 27, 2023

@nyctonio is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@PeerRich PeerRich changed the title [CAL-2654] Broken Icons in org invitation email #12112 chore: [CAL-2654] Broken Icons in org invitation email Oct 28, 2023
@PeerRich PeerRich enabled auto-merge (squash) October 28, 2023 17:13
@PeerRich PeerRich enabled auto-merge (squash) October 31, 2023 19:40
@PeerRich PeerRich merged commit 9d1ef0a into calcom:main Oct 31, 2023
26 of 34 checks passed
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
zomars pushed a commit that referenced this pull request Jan 29, 2024
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants