fix: Google Spam Polciy alert breaking embed layout in popup mode #12153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
2 tasks
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
hariombalhara
commented
Oct 30, 2023
| @@ -342,14 +342,17 @@ export default function Success(props: SuccessProps) { | |||
| <div | |||
| className={classNames( | |||
| shouldAlignCentrally ? "text-center" : "", | |||
| "flex items-end justify-center px-4 pb-20 pt-4 sm:block sm:p-0" | |||
| "flex items-end justify-center px-4 pb-20 pt-4 sm:flex sm:p-0" | |||
There was a problem hiding this comment.
I don't know why we were going from flex to block in sm
hariombalhara
commented
Oct 30, 2023
| )}> | ||
| <div | ||
| className={classNames("my-4 transition-opacity sm:my-0", isEmbed ? "" : " inset-0")} | ||
| className={classNames( | ||
| "main my-4 flex flex-col transition-opacity sm:my-0 ", |
There was a problem hiding this comment.
This one is also flex now
hariombalhara
commented
Oct 30, 2023
| )}> | ||
| <div | ||
| className={classNames("my-4 transition-opacity sm:my-0", isEmbed ? "" : " inset-0")} | ||
| className={classNames( | ||
| "main my-4 flex flex-col transition-opacity sm:my-0 ", |
There was a problem hiding this comment.
Switched main to be this wrapper element that contains alert as well, so that height calculation correctly includes alert
hariombalhara
force-pushed
the
10-30-Fix_Google_spam_policy_alert_layout_in_embed
branch
from
6212b0d
to
ce92c5e
Compare
hariombalhara
changed the base branch from
fix/less-recurring-bookings-failure
to
main
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 231 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/30/2023 12:56:08pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: ce92c5e Started: 10/30/2023 12:53:32pm UTC
|
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
2.98% (9)9 / 302 runsfailed over last 7 days |
46.03% (139)139 / 302 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
2.99% (9)9 / 301 runsfailed over last 7 days |
54.82% (165)165 / 301 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
0.33% (1)1 / 302 runfailed over last 7 days |
17.55% (53)53 / 302 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link should validate fields
Retry 1 • Initial Attempt |
0.68% (2)2 / 296 runsfailed over last 7 days |
13.18% (39)39 / 296 runsflaked over last 7 days |
sean-brydon
approved these changes
Oct 31, 2023
sean-brydon
deleted the
10-30-Fix_Google_spam_policy_alert_layout_in_embed
branch
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Nov 28, 2023
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
zomars
pushed a commit
that referenced
this pull request
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12151
Loom: https://www.loom.com/share/fbb38d07327142c8ba573feed497ff13
Type of change
How should this be tested?
See loom
Mandatory Tasks
Checklist