Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e): failsafe if no availabilities #12168

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix(e2e): failsafe if no availabilities #12168

merged 2 commits into from
Oct 31, 2023

Conversation

ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Oct 31, 2023 •
edited

What does this PR do?

This pr fixes e2e tests that are trying to select slots on the schedule the last day of the month, if there are no availabilities at all left during the month, we should click on the View Next Month button.

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 3:01pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 3:01pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2023 3:01pm
cal ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2023 3:01pm
cal-demo ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2023 3:01pm
qa ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2023 3:01pm
ui ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2023 3:01pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023 •
edited

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@zomars zomars added the core area: core, team members only label Oct 31, 2023
@ThyMinimalDev ThyMinimalDev changed the title fix(e2e): failsafe is no availabilities fix(e2e): failsafe if no availabilities Oct 31, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023 •
edited

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel DeploySentinel
Copy link

deploysentinel bot commented Oct 31, 2023 •
edited

Current Playwright Test Results Summary

✅ 231 Passing - ⚠️ 8 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/31/2023 04:08:51pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: c3f376d

Started: 10/31/2023 04:04:43pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
prefill logged in
Retry 1 • Initial Attempt
0% (0) 0 / 272 runs
failed over last 7 days
0.74% (2) 2 / 272 runs
flaked over last 7 days
📄   apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and Radio group Question Address and Radio group not required
Retry 1 • Initial Attempt
0% (0) 0 / 137 runs
failed over last 7 days
0.73% (1) 1 / 137 run
flaked over last 7 days
📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and select Question Phone and select required
Retry 1 • Initial Attempt
0% (0) 0 / 255 runs
failed over last 7 days
0.78% (2) 2 / 255 runs
flaked over last 7 days
📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration When event is paid and confirmed Payment should confirm pending payment booking
Retry 1 • Initial Attempt
0% (0) 0 / 311 runs
failed over last 7 days
1.93% (6) 6 / 311 runs
flaked over last 7 days
📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1 • Initial Attempt
6.81% (22) 22 / 323 runs
failed over last 7 days
11.15% (36) 36 / 323 runs
flaked over last 7 days
📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt
2.78% (9) 9 / 324 runs
failed over last 7 days
21.60% (70) 70 / 324 runs
flaked over last 7 days
📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

 2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt
16.82% (55) 55 / 327 runs
failed over last 7 days
81.04% (265) 265 / 327 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt
2.77% (9) 9 / 325 runs
failed over last 7 days
55.69% (181) 181 / 325 runs
flaked over last 7 days

View Detailed Build Results

@emrysal
Copy link
Contributor

emrysal commented Oct 31, 2023

No longer needed as we fixed the underlying issue :)

@emrysal emrysal closed this Oct 31, 2023
@keithwillcode
Copy link
Contributor

@emrysal @ThyMinimalDev Should we keep this fix around just for the case of running the test suite at, let's say, 11:58PM? Or cross that bridge when it happens?

@ThyMinimalDev
Copy link
Contributor Author

@emrysal @ThyMinimalDev Should we keep this fix around just for the case of running the test suite at, let's say, 11:58PM? Or cross that bridge when it happens?

we could, we have unit tests to ensure that the core logic is working, we should probably make specific e2e tests as well where there is actually no slots at all and assess that

@ThyMinimalDev ThyMinimalDev reopened this Oct 31, 2023
@ThyMinimalDev
Copy link
Contributor Author

we actually need a check for the end of the month on the e2e tests, otherwise tests will fail every end of month after 5pm since our seeded users don't have availabilities after that time

@keithwillcode keithwillcode enabled auto-merge (squash) October 31, 2023 16:04
@keithwillcode keithwillcode merged commit 58ab278 into main Oct 31, 2023
62 of 63 checks passed
@keithwillcode keithwillcode deleted the fix-e2e-regular-bookings-end-of-month branch October 31, 2023 16:10
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023
@ThyMinimalDev @hbjORbj
fix(e2e): failsafe if no availabilities (calcom#12168)
d81fcb2
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
@ThyMinimalDev @hbjORbj
fix(e2e): failsafe if no availabilities (calcom#12168)
b1bfd60
zomars pushed a commit that referenced this pull request Jan 29, 2024
@ThyMinimalDev @zomars
fix(e2e): failsafe if no availabilities (#12168)
b09edef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithwillcode keithwillcode keithwillcode approved these changes

@emrysal emrysal Awaiting requested review from emrysal

Assignees
No one assigned
Labels
core area: core, team members only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ThyMinimalDev @emrysal @keithwillcode @zomars