Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: phone-number-input #12266

Merged
merged 13 commits into from
Nov 27, 2023
Merged

fix: phone-number-input #12266

merged 13 commits into from
Nov 27, 2023
+26 −8

Conversation

Amit91848
Copy link
Contributor

@Amit91848 Amit91848 commented Nov 7, 2023 •
edited by Udit-takkar

What does this PR do?

a) of #12162

Screenshot (1)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2023

@Amit91848 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Nov 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023 •
edited

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@Amit91848 Amit91848 changed the title fix/phone-number-input fix: phone-number-input Nov 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023 •
edited

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Udit-takkar
Udit-takkar requested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see info badge here

Screenshot 2023-11-08 at 8 42 18 PM

Steps to reproduce

  1. Go to event type advanced settings
  2. Add a Booking questions of type phone

Also when there is only one location ( Attendee Phone Numeber)

Screenshot 2023-11-08 at 8 44 56 PM

@Amit91848
Copy link
Contributor Author

Made recommended changes @Udit-takkar

Single Location
Screenshot (2)

Booking Questions
Screenshot (3)

Multiple Locations
Screenshot (4)

@Udit-takkar
Copy link
Contributor

@Amit91848 e2e tests are failing

@Amit91848
Copy link
Contributor Author

I have no idea how to fix it. Can you guide me @Udit-takkar ?

Udit-takkar
Udit-takkar previously approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @Amit91848 I have all tests now

@Udit-takkar Udit-takkar enabled auto-merge (squash) November 14, 2023 19:19
@github-actions GitHub Actions
Copy link
Contributor

Hey there, there is a merge conflict, can you take a look?

@github-actions github-actions bot added the 🚨 merge conflict This PR has a merge conflict that has to be addressed label Nov 21, 2023
@Udit-takkar Udit-takkar enabled auto-merge (squash) November 21, 2023 15:41
Udit-takkar
Udit-takkar approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeerRich PeerRich merged commit 4524d72 into calcom:main Nov 27, 2023
27 of 35 checks passed
jakazzy pushed a commit to jakazzy/cal.com that referenced this pull request Dec 5, 2023
@Amit91848 @jakazzy
fix: phone-number-input (calcom#12266)
eb96771
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
@Amit91848 @hbjORbj
fix: phone-number-input (calcom#12266)
f13e606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udit-takkar Udit-takkar Udit-takkar approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working 🧹 Improvements Improvements to existing features. Mostly UX/UI Medium priority Created by Linear-GitHub Sync 🚨 merge conflict This PR has a merge conflict that has to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Amit91848 @CLAassistant @Udit-takkar @PeerRich