Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Sentry to edge #12304

Merged
merged 1 commit into from
Nov 10, 2023
Merged

feat: Add Sentry to edge #12304

merged 1 commit into from
Nov 10, 2023

Conversation

keithwillcode
Copy link
Contributor

What does this PR do?

This enables logging exceptions to Sentry from the edge

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Trigger an error from middleware/edge and ensure it makes it into Sentry

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@keithwillcode keithwillcode requested a review from a team November 9, 2023 19:22
@keithwillcode keithwillcode self-assigned this Nov 9, 2023
@keithwillcode keithwillcode added the Medium priority Created by Linear-GitHub Sync label Nov 9, 2023
Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 7:31pm
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 7:31pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 7:31pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Nov 9, 2023 7:31pm
cal-demo ⬜️ Ignored (Inspect) Nov 9, 2023 7:31pm
qa ⬜️ Ignored (Inspect) Nov 9, 2023 7:31pm
ui ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2023 7:31pm

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

Copy link
Contributor

github-actions bot commented Nov 9, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Nov 9, 2023

Current Playwright Test Results Summary

✅ 313 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/09/2023 07:39:28pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 1d64707

Started: 11/09/2023 07:30:22pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1Initial Attempt
0% (0) 0 / 257 runs
failed over last 7 days
5.06% (13) 13 / 257 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
20.45% (54) 54 / 264 runs
failed over last 7 days
74.62% (197) 197 / 264 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
1.51% (4) 4 / 265 runs
failed over last 7 days
55.85% (148) 148 / 265 runs
flaked over last 7 days

View Detailed Build Results


@exception
Copy link
Contributor

Nice.

@keithwillcode keithwillcode merged commit e4281a8 into main Nov 10, 2023
38 checks passed
@keithwillcode keithwillcode deleted the feat/add-sentry-to-edge branch November 10, 2023 11:47
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023
hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023
zomars pushed a commit that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin core area: core, team members only devops Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants