-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add teamId index on VerificationToken #12339
fix: add teamId index on VerificationToken #12339
Conversation
CAL-2696 Index missing on InvitationToken table (TeamId)
Fetching a TeamById triggers a number of Select queries on multiple tables in the database, including on InvitationToken where we don't have an index on TeamId, making this query extremely intense for the database.
cal.com/packages/features/ee/teams/components/AddNewTeamMembers.tsx Lines 36 to 39 in 809abd2
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending migrations.
Oh duh, good call. Sorry for the approval. |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Current Playwright Test Results Summary✅ 313 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/13/2023 01:40:16pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: a0d0738 Started: 11/13/2023 01:29:17pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
0.38% (1)1 / 260 runfailed over last 7 days |
31.54% (82)82 / 260 runsflaked over last 7 days |
📄 apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Long text Question Multiple Email and Long text not required
Retry 1 • Initial Attempt |
0% (0)0 / 249 runsfailed over last 7 days |
1.61% (4)4 / 249 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
1.09% (3)3 / 274 runsfailed over last 7 days |
55.47% (152)152 / 274 runsflaked over last 7 days |
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
17.22% (47)47 / 273 runsfailed over last 7 days |
76.56% (209)209 / 273 runsflaked over last 7 days |
📄 apps/web/playwright/insights.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Insights should test download button
Retry 1 • Initial Attempt |
0% (0)0 / 261 runsfailed over last 7 days |
11.11% (29)29 / 261 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Teams - NonOrg Non admin team members cannot create team in org
Retry 1 • Initial Attempt |
0% (0)0 / 265 runsfailed over last 7 days |
35.09% (93)93 / 265 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.75% (2)2 / 265 runsfailed over last 7 days |
37.74% (100)100 / 265 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
* fix: add teamId index on InvitationToken * fix: add migration
* fix: add teamId index on InvitationToken * fix: add migration
* fix: add teamId index on InvitationToken * fix: add migration
What does this PR do?
Fixes # CAL-2696
Add missing index TeamId on VerificationToken
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist