Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: More admin options for organizations #12424

Merged
merged 2 commits into from
Dec 19, 2023
Merged

feat: More admin options for organizations #12424

merged 2 commits into from
Dec 19, 2023

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Nov 18, 2023 •
edited

What does this PR do?

Stacked over #12358. Please merge that first.

Admin Options for Organizations

  • Ability to publish an org
  • Edit
    • Name
    • orgAutoAcceptEmail
    • Slug
      • Delete previous domain and record on Vercel and Cloudflare
      • Create new domain and record on Vercel and Cloudflare
  • Ability to delete an organization.
    • Delete domain on Vercel
    • Delete DNS record on cloudflare

Loom Demo

Other fixes

  • Fixes booker URLs shown in Other Team Profile View and Create New Team Views
  • Disable Error Redaction locally.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel Vercel
Copy link

vercel bot commented Nov 18, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 11:20am
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 11:20am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 11:20am
qa 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 11:20am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 11:20am
cal-demo ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 11:20am
ui ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 11:20am

@hariombalhara
Copy link
Member Author

hariombalhara commented Nov 18, 2023 •
edited

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@hariombalhara hariombalhara mentioned this pull request Nov 18, 2023
Merged
11 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2023 •
edited

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@hariombalhara hariombalhara force-pushed the 11-18-feat_More_admin_options_for_organizations branch from a7451b9 to 0b23a4a Compare November 20, 2023 05:40
@hariombalhara hariombalhara force-pushed the 11-18-feat_More_admin_options_for_organizations branch from 0b23a4a to 5e7e22a Compare November 20, 2023 11:10
@hariombalhara hariombalhara changed the base branch from 11-14-fix_Wrong_links_for_event_and_team to main November 20, 2023 11:10
@zomars zomars added the core area: core, team members only label Nov 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023 •
edited

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/settings/admin/organizations/[id]/edit 252.53 KB 415.61 KB 118.74%

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/settings/admin/organizations 254.02 KB 417.09 KB 119.17% (🟡 +0.21%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel DeploySentinel
Copy link

deploysentinel bot commented Nov 20, 2023 •
edited

Current Playwright Test Results Summary

✅ 318 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/21/2023 05:28:57am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: ee48a8c

Started: 11/21/2023 05:20:20am UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt
0.41% (1) 1 / 245 run
failed over last 7 days
32.65% (80) 80 / 245 runs
flaked over last 7 days
📄   apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Phone Question Checkbox Group required and Phone required
Retry 1 • Initial Attempt
0% (0) 0 / 243 runs
failed over last 7 days
1.23% (3) 3 / 243 runs
flaked over last 7 days
📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

 2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt
2.97% (8) 8 / 269 runs
failed over last 7 days
57.62% (155) 155 / 269 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt
20.45% (55) 55 / 269 runs
failed over last 7 days
74.72% (201) 201 / 269 runs
flaked over last 7 days
📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1 • Initial Attempt
13.55% (34) 34 / 251 runs
failed over last 7 days
13.55% (34) 34 / 251 runs
flaked over last 7 days

View Detailed Build Results

@hariombalhara hariombalhara force-pushed the 11-18-feat_More_admin_options_for_organizations branch from 5e7e22a to 13afd95 Compare November 20, 2023 14:13
@hariombalhara hariombalhara force-pushed the 11-18-feat_More_admin_options_for_organizations branch from 13afd95 to ee48a8c Compare November 21, 2023 05:11
@hariombalhara hariombalhara changed the base branch from main to 11-14-fix_Wrong_links_for_event_and_team November 21, 2023 12:30
@hariombalhara hariombalhara force-pushed the 11-18-feat_More_admin_options_for_organizations branch from ee48a8c to 856ed7a Compare November 21, 2023 12:30
@hariombalhara hariombalhara force-pushed the 11-18-feat_More_admin_options_for_organizations branch from 3ed696a to 5e30855 Compare December 5, 2023 11:48
This was referenced Dec 11, 2023
Open
Closed
Closed
@hariombalhara hariombalhara force-pushed the 11-18-feat_More_admin_options_for_organizations branch from 5e30855 to 7a36a0b Compare December 12, 2023 13:42
@hariombalhara
Copy link
Member Author

hariombalhara commented Dec 12, 2023 •
edited

Thanks for the review @ThyMinimalDev. Addressed all comments.

Also, FYI it's a stacked PR. So, I would really appreciate if you could review the target branch PR as well as that should be merged first.

Base automatically changed from 11-14-fix_Wrong_links_for_event_and_team to main December 19, 2023 09:33
@hariombalhara hariombalhara force-pushed the 11-18-feat_More_admin_options_for_organizations branch from e732246 to 9c0baa9 Compare December 19, 2023 11:09
@hariombalhara
Copy link
Member Author

@ThyMinimalDev No longer a stacked PR now. It's targeted to main now. If you could do a final review that would be great.

ThyMinimalDev
ThyMinimalDev approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@hariombalhara hariombalhara merged commit 5886792 into main Dec 19, 2023
24 checks passed
@hariombalhara hariombalhara deleted the 11-18-feat_More_admin_options_for_organizations branch December 19, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udit-takkar Udit-takkar Udit-takkar left review comments

@sean-brydon sean-brydon sean-brydon left review comments

@ThyMinimalDev ThyMinimalDev ThyMinimalDev approved these changes

Assignees
No one assigned
Labels
core area: core, team members only ❗️ .env changes contains changes to env variables Medium priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hariombalhara @PeerRich @ThyMinimalDev @Udit-takkar @sean-brydon @zomars