refactor: invite members handler #12442
Merged
+453
−308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAL-2698 Refactor InviteMember handler
file: packages/trpc/server/routers/viewer/teams/inviteMember/inviteMember.handler.ts Currently inviteMember allows bulk invite of team members, which can be overloading our database very quickly the problems are the following:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
ThyMinimalDev
force-pushed
the
cal-2698-refactor-invitemember-handler
branch
from
25e43a4
to
d0e6d34
Compare
sean-brydon
reviewed
Nov 20, 2023
packages/trpc/server/routers/viewer/teams/inviteMember/utils.ts
Outdated
Show resolved
Hide resolved
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 38 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/27/2023 08:20:51am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: c9bf49e Started: 11/27/2023 08:19:42am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1 • Initial Attempt |
3.47% (9)9 / 259 runsfailed over last 7 days |
17.37% (45)45 / 259 runsflaked over last 7 days |
sean-brydon
reviewed
Nov 20, 2023
packages/trpc/server/routers/viewer/teams/inviteMember/utils.ts
Outdated
Show resolved
Hide resolved
ThyMinimalDev
commented
Nov 23, 2023
Comment on lines
+203
to
+209
| teams: { | ||
| create: { | ||
| teamId: input.teamId, | ||
| role: input.role as MembershipRole, | ||
| accepted: autoAccept, // If the user is invited to a child team, they are automatically accepted | ||
| }, | ||
| }, |
There was a problem hiding this comment.
we could conditionally create the membership to the Organization here instead of doing it in the if parentId statement below, but it would not have any impact since prisma would still make different sql queries
sean-brydon
approved these changes
Nov 27, 2023
jakazzy
pushed a commit
to jakazzy/cal.com
that referenced
this pull request
Dec 5, 2023
* refactor: invite members handler * fixup! refactor: invite members handler * fixup! fixup! refactor: invite members handler * refactor: promise all settled send emails * fixup! refactor: promise all settled send emails * fixup! fixup! refactor: promise all settled send emails * fixup! fixup! fixup! refactor: promise all settled send emails * fix: opening team invite link in email throws error on signup page * fixup! Merge branch 'main' into cal-2698-refactor-invitemember-handler * fix: centralize validation if invitee can be invited * fix: improve select query and fix tests * fixup! Merge branch 'main' into cal-2698-refactor-invitemember-handler * rename functions and add some tests
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
* refactor: invite members handler * fixup! refactor: invite members handler * fixup! fixup! refactor: invite members handler * refactor: promise all settled send emails * fixup! refactor: promise all settled send emails * fixup! fixup! refactor: promise all settled send emails * fixup! fixup! fixup! refactor: promise all settled send emails * fix: opening team invite link in email throws error on signup page * fixup! Merge branch 'main' into cal-2698-refactor-invitemember-handler * fix: centralize validation if invitee can be invited * fix: improve select query and fix tests * fixup! Merge branch 'main' into cal-2698-refactor-invitemember-handler * rename functions and add some tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor trpc invite handler to treat the operations as batches
Type of change
How should this be tested?
Mandatory Tasks
Checklist